Ticket #58484: patch.58484.20231019.5.diff

src/wp-admin/includes/class-wp-debug-data.php

@@ -20 +20 @@
                 wp_update_themes();
         }
 
+        /*
+        * Returns the value of a defined constant. If the constant is defined as empty, it will return "Defined as empty (string)".
+        * If the constant is a boolean (false) it will return "Defined as false (boolan)"
+        * If the constant is not defined, it will return "Undefined"
+        */
+        private static function get_define_info( $constant_name ) {
+                // Check WP_ENVIRONMENT_TYPE.
+                if ( defined( $constant_name ) ) {
+                        $value = constant( $constant_name );
+                        if ( !$value ) {
+                                // Strict check for boolean equals (bool)false first
+                                if ( $value === false ) {
+                                        $value = __( 'Defined as false (boolan)' );
+                                } else {                                
+                                        $value = __( 'Defined as empty (string)' );
+                                }
+                        }
+                } else {
+                        $value = __( 'Undefined' );
+                }
+                return $value;
+        }
+
         /**
          * Static function for generating site debug data when required.
          *
@@ -236 +259 @@
                         $compress_css_debug = 'undefined';
                 }
 
-                // Check WP_ENVIRONMENT_TYPE.
-                if ( defined( 'WP_ENVIRONMENT_TYPE' ) && WP_ENVIRONMENT_TYPE ) {
-                        $wp_environment_type = WP_ENVIRONMENT_TYPE;
-                } else {
-                        $wp_environment_type = __( 'Undefined' );
-                }
-
                 $info['wp-constants'] = array(
                         'label'       => __( 'WordPress Constants' ),
                         'description' => __( 'These settings alter where and how parts of WordPress are loaded.' ),
@@ -254 +270 @@
                                 ),
                                 'WP_HOME'             => array(
                                         'label' => 'WP_HOME',
-                                        'value' => ( defined( 'WP_HOME' ) ? WP_HOME : __( 'Undefined' ) ),
-                                        'debug' => ( defined( 'WP_HOME' ) ? WP_HOME : 'undefined' ),
+                                        'value' => self::get_define_info( 'WP_HOME' ),
+                                        'debug' => self::get_define_info( 'WP_HOME' ),
                                 ),
                                 'WP_SITEURL'          => array(
                                         'label' => 'WP_SITEURL',
-                                        'value' => ( defined( 'WP_SITEURL' ) ? WP_SITEURL : __( 'Undefined' ) ),
-                                        'debug' => ( defined( 'WP_SITEURL' ) ? WP_SITEURL : 'undefined' ),
+                                        'value' => self::get_define_info( 'WP_SITEURL' ),
+                                        'debug' => self::get_define_info( 'WP_SITEURL' ),
                                 ),
                                 'WP_CONTENT_DIR'      => array(
                                         'label' => 'WP_CONTENT_DIR',
@@ -330 +346 @@
                                 ),
                                 'DB_CHARSET'          => array(
                                         'label' => 'DB_CHARSET',
-                                        'value' => ( defined( 'DB_CHARSET' ) ? DB_CHARSET : __( 'Undefined' ) ),
-                                        'debug' => ( defined( 'DB_CHARSET' ) ? DB_CHARSET : 'undefined' ),
+                                        'value' => self::get_define_info( 'DB_CHARSET' ),
+                                        'debug' => self::get_define_info( 'DB_CHARSET' ),
                                 ),
                                 'DB_COLLATE'          => array(
                                         'label' => 'DB_COLLATE',
-                                        'value' => ( defined( 'DB_COLLATE' ) ? DB_COLLATE : __( 'Undefined' ) ),
-                                        'debug' => ( defined( 'DB_COLLATE' ) ? DB_COLLATE : 'undefined' ),
+                                        'value' => self::get_define_info( 'DB_COLLATE' ),
+                                        'debug' => self::get_define_info( 'DB_COLLATE' ),
                                 ),
                         ),
                 );