Ticket #58988: 58988.patch

src/wp-admin/includes/ajax-actions.php

@@ -148 +148 @@
          * Require $term_search_min_chars chars for matching (default: 2)
          * ensure it's a non-negative, non-zero integer.
          */
-        if ( ( 0 == $term_search_min_chars ) || ( strlen( $search ) < $term_search_min_chars ) ) {
+        if ( ( 0 === $term_search_min_chars ) || ( strlen( $search ) < $term_search_min_chars ) ) {
                 wp_die();
         }
 
@@ -205 +205 @@
                 $force_gzip = ( defined( 'ENFORCE_GZIP' ) && ENFORCE_GZIP );
                 $test_str   = '"wpCompressionTest Lorem ipsum dolor sit amet consectetuer mollis sapien urna ut a. Eu nonummy condimentum fringilla tempor pretium platea vel nibh netus Maecenas. Hac molestie amet justo quis pellentesque est ultrices interdum nibh Morbi. Cras mattis pretium Phasellus ante ipsum ipsum ut sociis Suspendisse Lorem. Ante et non molestie. Porta urna Vestibulum egestas id congue nibh eu risus gravida sit. Ac augue auctor Ut et non a elit massa id sodales. Elit eu Nulla at nibh adipiscing mattis lacus mauris at tempus. Netus nibh quis suscipit nec feugiat eget sed lorem et urna. Pellentesque lacus at ut massa consectetuer ligula ut auctor semper Pellentesque. Ut metus massa nibh quam Curabitur molestie nec mauris congue. Volutpat molestie elit justo facilisis neque ac risus Ut nascetur tristique. Vitae sit lorem tellus et quis Phasellus lacus tincidunt nunc Fusce. Pharetra wisi Suspendisse mus sagittis libero lacinia Integer consequat ac Phasellus. Et urna ac cursus tortor aliquam Aliquam amet tellus volutpat Vestibulum. Justo interdum condimentum In augue congue tellus sollicitudin Quisque quis nibh."';
 
-                if ( 1 == $_GET['test'] ) {
+                if ( 1 === $_GET['test'] ) {
                         echo $test_str;
                         wp_die();
-                } elseif ( 2 == $_GET['test'] ) {
+                } elseif ( 2 === $_GET['test'] ) {
                         if ( ! isset( $_SERVER['HTTP_ACCEPT_ENCODING'] ) ) {
                                 wp_die( -1 );
                         }
@@ -509 +509 @@
         }
 
         // Only do the expensive stuff on a page-break, and about 1 other time per page.
-        if ( 0 == $total % $per_page || 1 == mt_rand( 1, $per_page ) ) {
+        if ( 0 === $total % $per_page || 1 === mt_rand( 1, $per_page ) ) {
                 $post_id = 0;
                 // What type of comment count are we looking for?
                 $status = 'all';
@@ -729 +729 @@
         $status = wp_get_comment_status( $comment );
         $delta  = -1;
 
-        if ( isset( $_POST['trash'] ) && 1 == $_POST['trash'] ) {
+        if ( isset( $_POST['trash'] ) && 1 === $_POST['trash'] ) {
                 if ( 'trash' === $status ) {
                         wp_die( time() );
                 }
 
                 $r = wp_trash_comment( $comment );
-        } elseif ( isset( $_POST['untrash'] ) && 1 == $_POST['untrash'] ) {
+        } elseif ( isset( $_POST['untrash'] ) && 1 === $_POST['untrash'] ) {
                 if ( 'trash' !== $status ) {
                         wp_die( time() );
                 }
@@ -752 +752 @@
                 }
 
                 $r = wp_spam_comment( $comment );
-        } elseif ( isset( $_POST['unspam'] ) && 1 == $_POST['unspam'] ) {
+        } elseif ( isset( $_POST['unspam'] ) && 1 === $_POST['unspam'] ) {
                 if ( 'spam' !== $status ) {
                         wp_die( time() );
                 }
@@ -763 +763 @@
                 if ( ! isset( $_POST['comment_status'] ) || 'spam' !== $_POST['comment_status'] ) {
                         $delta = 1;
                 }
-        } elseif ( isset( $_POST['delete'] ) && 1 == $_POST['delete'] ) {
+        } elseif ( isset( $_POST['delete'] ) && 1 === $_POST['delete'] ) {
                 $r = wp_delete_comment( $comment );
         } else {
                 wp_die( -1 );
@@ -996 +996 @@
 
         $current = wp_get_comment_status( $comment );
 
-        if ( isset( $_POST['new'] ) && $_POST['new'] == $current ) {
+        if ( isset( $_POST['new'] ) && $_POST['new'] === $current ) {
                 wp_die( time() );
         }
 
@@ -1380 +1380 @@
         if ( ! empty( $_POST['approve_parent'] ) ) {
                 $parent = get_comment( $comment_parent );
 
-                if ( $parent && '0' === $parent->comment_approved && $parent->comment_post_ID == $comment_post_id ) {
+                if ( $parent && '0' === $parent->comment_approved && $parent->comment_post_ID === $comment_post_id ) {
                         if ( ! current_user_can( 'edit_comment', $parent->comment_ID ) ) {
                                 wp_die( -1 );
                         }
@@ -1479 +1479 @@
         }
 
         $position      = ( isset( $_POST['position'] ) && (int) $_POST['position'] ) ? (int) $_POST['position'] : '-1';
-        $checkbox      = ( isset( $_POST['checkbox'] ) && true == $_POST['checkbox'] ) ? 1 : 0;
+        $checkbox      = ( isset( $_POST['checkbox'] ) && true === $_POST['checkbox'] ) ? 1 : 0;
         $wp_list_table = _get_list_table( $checkbox ? 'WP_Comments_List_Table' : 'WP_Post_Comments_List_Table', array( 'screen' => 'edit-comments' ) );
 
         $comment = get_comment( $comment_id );
@@ -2401 +2401 @@
 
         foreach ( (array) $wp_registered_widget_updates as $name => $control ) {
 
-                if ( $name == $id_base ) {
+                if ( $name === $id_base ) {
                         if ( ! is_callable( $control['callback'] ) ) {
                                 continue;
                         }
@@ -2727 +2727 @@
                 check_ajax_referer( "set_post_thumbnail-$post_id" );
         }
 
-        if ( '-1' == $thumbnail_id ) {
+        if ( '-1' === $thumbnail_id ) {
                 if ( delete_post_thumbnail( $post_id ) ) {
                         $return = _wp_post_thumbnail_html( null, $post_id );
                         $json ? wp_send_json_success( $return ) : wp_die( $return );
@@ -3308 +3308 @@
                 // If this attachment is unattached, attach it. Primarily a back compat thing.
                 $insert_into_post_id = (int) $_POST['post_id'];
 
-                if ( 0 == $post->post_parent && $insert_into_post_id ) {
+                if ( 0 === $post->post_parent && $insert_into_post_id ) {
                         wp_update_post(
                                 array(
                                         'ID'          => $id,
@@ -3319 +3319 @@
         }
 
         $url = empty( $attachment['url'] ) ? '' : $attachment['url'];
-        $rel = ( strpos( $url, 'attachment_id' ) || get_attachment_link( $id ) == $url );
+        $rel = ( strpos( $url, 'attachment_id' ) || get_attachment_link( $id ) === $url );
 
         remove_filter( 'media_send_to_editor', 'image_media_send_to_editor' );
 
@@ -3991 +3991 @@
                         $wp_site_icon = new WP_Site_Icon();
 
                         // Skip creating a new attachment if the attachment is a Site Icon.
-                        if ( get_post_meta( $attachment_id, '_wp_attachment_context', true ) == $context ) {
+                        if ( get_post_meta( $attachment_id, '_wp_attachment_context', true ) === $context ) {
 
                                 // Delete the temporary cropped file, we don't need it.
                                 wp_delete_file( $cropped );