Make WordPress Core

Ticket #59250: 59520-with-tests-and-comments.diff

File 59520-with-tests-and-comments.diff, 2.0 KB (added by shooper, 14 months ago)

Updated the patch to include comments on the filter so that the Code Reference documentation is updated properly.

  • src/wp-admin/includes/misc.php

    diff --git src/wp-admin/includes/misc.php src/wp-admin/includes/misc.php
    index 090282062f..078434da5e 100644
    All at ###SITENAME### 
    15311531                $site_title = parse_url( home_url(), PHP_URL_HOST );
    15321532        }
    15331533
     1534        $subject = sprintf(
     1535        /* translators: New admin email address notification email subject. %s: Site title. */
     1536                __( '[%s] New Admin Email Address' ),
     1537                $site_title
     1538        );
     1539
     1540        /**
     1541         * Filters the subject of the email sent when a change of site admin email address is attempted.
     1542         *
     1543         * @since 6.5.0
     1544         *
     1545         * @param string $subject      Subject of the email.
     1546         */
     1547        $subject = apply_filters( 'new_admin_email_subject', $subject );
     1548
    15341549        wp_mail(
    15351550                $value,
    1536                 sprintf(
    1537                         /* translators: New admin email address notification email subject. %s: Site title. */
    1538                         __( '[%s] New Admin Email Address' ),
    1539                         $site_title
    1540                 ),
     1551                $subject,
    15411552                $content
    15421553        );
    15431554
  • tests/phpunit/tests/admin/includesMisc.php

    diff --git tests/phpunit/tests/admin/includesMisc.php tests/phpunit/tests/admin/includesMisc.php
    index ce0ef7c6c5..2df7f66145 100644
    class Tests_Admin_IncludesMisc extends WP_UnitTestCase { 
    2727                        $this->assertSame( $v, url_shorten( $k ) );
    2828                }
    2929        }
     30
     31        /**
     32         * @ticket 59520
     33         */
     34        public function test_new_admin_email_subject_filter() {
     35                // Default value
     36                $mailer = tests_retrieve_phpmailer_instance();
     37                update_option_new_admin_email( 'old@example.com', 'new@example.com' );
     38                $this->assertEquals( '[Test Blog] New Admin Email Address', $mailer->get_sent()->subject );
     39
     40                // Filtered value
     41                add_filter(
     42                        'new_admin_email_subject',
     43                        function () {
     44                                return 'Filtered Admin Email Address';
     45                        },
     46                        10,
     47                        1
     48                );
     49
     50                $mailer->mock_sent = array();
     51
     52                $mailer = tests_retrieve_phpmailer_instance();
     53                update_option_new_admin_email( 'old@example.com', 'new@example.com' );
     54                $this->assertEquals( 'Filtered Admin Email Address', $mailer->get_sent()->subject );
     55        }
    3056}