Ticket #59389: 59389.diff

tests/phpunit/tests/media/getPostGalleries.php

@@ -575 +575 @@
 
                 }
 
-                $ids_joined = join( ',', $ids );
+                $ids_joined = implode( ',', $ids );
 
                 $global_post_id = self::factory()->post->create(
                         array(
@@ -844 +844 @@
 
                 }
 
-                $ids1_joined = join( ',', array_slice( $ids, 0, 3 ) );
-                $ids2_joined = join( ',', array_slice( $ids, 3, 3 ) );
+                $ids1_joined = implode( ',', array_slice( $ids, 0, 3 ) );
+                $ids2_joined = implode( ',', array_slice( $ids, 3, 3 ) );
 
                 $blob = <<<BLOB
 [gallery ids="$ids1_joined"]
@@ -907 +907 @@
 
                 }
 
-                $ids1_joined = join( ',', array_slice( $ids, 0, 3 ) );
-                $ids2_joined = join( ',', array_slice( $ids, 3, 3 ) );
+                $ids1_joined = implode( ',', array_slice( $ids, 0, 3 ) );
+                $ids2_joined = implode( ',', array_slice( $ids, 3, 3 ) );
                 $blob        = <<<BLOB
 [gallery ids="$ids1_joined" type="type" foo="bar"]
 

tests/phpunit/tests/media.php

@@ -552 +552 @@
                         $ids2_srcs[] = 'http://' . WP_TESTS_DOMAIN . '/wp-content/uploads/' . "image$i.jpg";
                 }
 
-                $ids1_joined = join( ',', array_slice( $ids1, 0, 3 ) );
-                $ids2_joined = join( ',', array_slice( $ids2, 3, 3 ) );
+                $ids1_joined = implode( ',', array_slice( $ids1, 0, 3 ) );
+                $ids2_joined = implode( ',', array_slice( $ids2, 3, 3 ) );
 
                 $blob    = <<<BLOB
 [gallery ids="$ids1_joined"]
@@ -638 +638 @@
                         $imgs[]     = '<figure><img src="' . $url . '" data-id="' . $i . '" /></figure>';
                 }
 
-                $imgs1_joined = join( "\n", array_slice( $imgs, 0, 3 ) );
-                $imgs2_joined = join( "\n", array_slice( $imgs, 3, 3 ) );
+                $imgs1_joined = implode( "\n", array_slice( $imgs, 0, 3 ) );
+                $imgs2_joined = implode( "\n", array_slice( $imgs, 3, 3 ) );
 
                 $blob    = <<<BLOB
 <!-- wp:gallery -->
@@ -677 +677 @@
 
                 }
 
-                $ids1_joined = join( ',', array_slice( $ids, 0, 3 ) );
-                $ids2_joined = join( ',', array_slice( $ids, 3, 3 ) );
+                $ids1_joined = implode( ',', array_slice( $ids, 0, 3 ) );
+                $ids2_joined = implode( ',', array_slice( $ids, 3, 3 ) );
 
                 $blob    = <<<BLOB
 <!-- wp:gallery {"ids":[$ids1_joined]} -->
@@ -718 +718 @@
                         $imgs[]     = '<figure><img src="' . $url . '" data-id="' . $i . '" /></figure>';
                 }
 
-                $ids1_joined  = join( "\n", array_slice( $ids, 0, 3 ) );
-                $ids2_joined  = join( "\n", array_slice( $ids, 3, 3 ) );
-                $imgs2_joined = join( "\n", array_slice( $imgs, 3, 3 ) );
+                $ids1_joined  = implode( "\n", array_slice( $ids, 0, 3 ) );
+                $ids2_joined  = implode( "\n", array_slice( $ids, 3, 3 ) );
+                $imgs2_joined = implode( "\n", array_slice( $imgs, 3, 3 ) );
 
                 $blob    = <<<BLOB
 [gallery ids="$ids1_joined"]
@@ -762 +762 @@
 
                 }
 
-                $imgs_joined = join( "\n", $imgs );
+                $imgs_joined = implode( "\n", $imgs );
 
                 $blob    = <<<BLOB
 <!-- wp:columns -->
@@ -805 +805 @@
 
                 }
 
-                $imgs_joined = join( "\n", $imgs );
+                $imgs_joined = implode( "\n", $imgs );
 
                 $blob    = <<<BLOB
 <!-- wp:gallery -->