Ticket #60247: 60247.2.diff

src/js/_enqueues/admin/comment.js

@@ -70 +70 @@
          * @param {Event} event The event object.
          * @return {void}
          */
-        $timestampdiv.find('.save-timestamp').on( 'click', function( event ) { // Crazyhorse - multiple OK cancels.
+        $timestampdiv.find('.save-timestamp').on( 'click', function( event ) { // Crazyhorse branch - multiple OK cancels.
                 var aa = $('#aa').val(), mm = $('#mm').val(), jj = $('#jj').val(), hh = $('#hh').val(), mn = $('#mn').val(),
                         newD = new Date( aa, mm - 1, jj, hh, mn );
 

src/js/_enqueues/admin/post.js

@@ -889 +889 @@
                 });
 
                 // Set the selected visibility as current.
-                $postVisibilitySelect.find('.save-post-visibility').on( 'click', function( event ) { // Crazyhorse - multiple OK cancels.
+                $postVisibilitySelect.find('.save-post-visibility').on( 'click', function( event ) { // Crazyhorse branch - multiple OK cancels.
                         var visibilityLabel = '', selectedVisibility = $postVisibilitySelect.find('input:radio:checked').val();
 
                         $postVisibilitySelect.slideUp('fast');
@@ -945 +945 @@
                 });
 
                 // Save the changed timestamp.
-                $timestampdiv.find('.save-timestamp').on( 'click', function( event ) { // Crazyhorse - multiple OK cancels.
+                $timestampdiv.find('.save-timestamp').on( 'click', function( event ) { // Crazyhorse branch - multiple OK cancels.
                         if ( updateText() ) {
                                 $timestampdiv.slideUp('fast');
                                 $timestampdiv.siblings('a.edit-timestamp').show().trigger( 'focus' );

src/wp-includes/class-simplepie.php

@@ -340 +340 @@
 
 /**
  * RSS 2.0 Namespace
- * (Stupid, I know, but I'm certain it will confuse people less with support.)
+ * (I know, but I'm certain it will confuse people less with support.)
  */
 define('SIMPLEPIE_NAMESPACE_RSS_20', '');
 
@@ -1208 +1208 @@
          * Set options to make SP as fast as possible
          *
          * Forgoes a substantial amount of data sanitization in favor of speed. This
-         * turns SimplePie into a dumb parser of feeds.
+         * turns SimplePie into an dumb parser of feeds.
          *
          * @param bool $set Whether to set them or not
          */

src/wp-includes/class-wp-theme.php

@@ -507 +507 @@
                                 }
                                 return;
                         }
-                        // Set the parent. Pass the current instance so we can do the crazy checks above and assess errors.
+                        // Set the parent. Pass the current instance so we can do the checks above and assess errors.
                         $this->parent = new WP_Theme( $this->template, isset( $theme_root_template ) ? $theme_root_template : $this->theme_root, $this );
                 }
 

src/wp-includes/class-wp-xmlrpc-server.php

@@ -6939 +6939 @@
                         return $this->pingback_error( 48, __( 'The pingback has already been registered.' ) );
                 }
 
-                // Very stupid, but gives time to the 'from' server to publish!
+                /*
+                 * The remote site may have sent the pingback before it finished publishing its own content
+                 * containing this pingback URL. If that happens then it won't be immediately possible to fetch
+                 * the pinging post; adding a small delay reduces the likelihood of this happening.
+                 * 
+                 * While there are more robust methods than calling `sleep()` here (because `sleep()` merely
+                 * mitigates the risk of requesting the remote post before it's available), this is effective
+                 * enough for most cases and avoids introducing more complexity into this code.
+                 *
+                 * One way to improve the reliability of this code might be to add failure-handling to the remote
+                 * fetch and retry up to a set number of times if it receives a 404. This could also handle 401 and
+                 * 403 responses to differentiate the "does not exist" failure from the "may not access" failure.
+                 */
                 sleep( 1 );
 
                 $remote_ip = preg_replace( '/[^0-9a-fA-F:., ]/', '', $_SERVER['REMOTE_ADDR'] );

src/wp-includes/shortcodes.php

@@ -504 +504 @@
                                 $element = preg_replace_callback( "/$pattern/", 'do_shortcode_tag', $element );
                         }
 
-                        // Looks like we found some crazy unfiltered HTML. Skipping it for confidence.
+                        // Looks like we found some unexpected unfiltered HTML. Skipping it for confidence.
                         $element = strtr( $element, $trans );
                         continue;
                 }

src/wp-includes/theme.php

@@ -2789 +2789 @@
                          * the constant is always accurate (and is not defined later,  overriding our value).
                          * As stated above, the first value wins.
                          * Once we get to wp_loaded (just-in-time), define any constants we haven't already.
-                         * Constants are lame. Don't reference them. This is just for backward compatibility.
+                         * Constants should be avoided. Don't reference them. This is just for backward compatibility.
                          */
 
                         if ( defined( 'NO_HEADER_TEXT' ) ) {