Ticket #6644: prepared_queries6.diff

wp-admin/update-links.php

@@ -36 +36 @@
         $returns = explode("\n", $body);
 
         foreach ($returns as $return) :
-                $time = $wpdb->escape( substr($return, 0, 19) );
-                $uri = $wpdb->escape( preg_replace('/(.*?) | (.*?)/', '$2', $return) );
-                $wpdb->query("UPDATE $wpdb->links SET link_updated = '$time' WHERE link_url = '$uri'");
+                $time = substr($return, 0, 19);
+                $uri = preg_replace('/(.*?) | (.*?)/', '$2', $return);
+                $wpdb->query( $wpdb->prepare("UPDATE $wpdb->links SET link_updated = %s WHERE link_url = %s", $time, $uri) );
         endforeach;
 }
 ?>

wp-admin/edit-comments.php

@@ -12 +12 @@
         $comments_deleted = $comments_approved = $comments_unapproved = $comments_spammed = 0;
         foreach ($_REQUEST['delete_comments'] as $comment) : // Check the permissions on each
                 $comment = (int) $comment;
-                $post_id = (int) $wpdb->get_var("SELECT comment_post_ID FROM $wpdb->comments WHERE comment_ID = $comment");
-                // $authordata = get_userdata( $wpdb->get_var("SELECT post_author FROM $wpdb->posts WHERE ID = $post_id") );
+                $post_id = (int) $wpdb->get_var( $wpdb->prepare( "SELECT comment_post_ID FROM $wpdb->comments WHERE comment_ID = %d", $comment) );
                 if ( !current_user_can('edit_post', $post_id) )
                         continue;
                 if ( !empty( $_REQUEST['spamit'] ) ) {

wp-admin/admin-ajax.php

@@ -15 +15 @@
 
         if ( strstr( $s, ',' ) )
                 die; // it's a multiple tag insert, we won't find anything
-        $results = $wpdb->get_col( "SELECT name FROM $wpdb->terms WHERE name LIKE ('%$s%')" );
+        $results = $wpdb->get_col( $wpdb->prepare("SELECT name FROM $wpdb->terms WHERE name LIKE (%s)", '%' . $s . '%') );
         echo join( $results, "\n" );
         die;
 }

wp-admin/includes/comment.php

@@ -3 +3 @@
 function comment_exists($comment_author, $comment_date) {
         global $wpdb;
 
-        return $wpdb->get_var("SELECT comment_post_ID FROM $wpdb->comments
-                        WHERE comment_author = '$comment_author' AND comment_date = '$comment_date'");
+        return $wpdb->get_var( $wpdb->prepare("SELECT comment_post_ID FROM $wpdb->comments
+                        WHERE comment_author = %s AND comment_date = %s", $comment_author, $comment_date) );
 }
 
 function edit_comment() {
@@ -67 +67 @@
 function get_pending_comments_num( $post_id ) {
         global $wpdb;
         $post_id = (int) $post_id;
-        $pending = $wpdb->get_var( "SELECT COUNT(*) FROM $wpdb->comments WHERE comment_post_ID = $post_id AND comment_approved = '0'" );
+        $pending = $wpdb->get_var( $wpdb->prepare("SELECT COUNT(*) FROM $wpdb->comments WHERE comment_post_ID = %d AND comment_approved = '0'", $post_id) );
         return $pending;
 }