Ticket #6644: prepared_queries7.diff

wp-admin/includes/bookmark.php

@@ -47 +47 @@
 
         wp_delete_object_term_relationships($link_id, 'link_category');
 
-        $wpdb->query("DELETE FROM $wpdb->links WHERE link_id = '$link_id'");
+        $wpdb->query( $wpdb->prepare("DELETE FROM $wpdb->links WHERE link_id = %d", $link_id) );
 
         do_action('deleted_link', $link_id);
 
@@ -119 +119 @@
         }
 
         if ( $update ) {
-                $wpdb->query("UPDATE $wpdb->links SET link_url='$link_url',
-                        link_name='$link_name', link_image='$link_image',
-                        link_target='$link_target',
-                        link_visible='$link_visible', link_description='$link_description',
-                        link_rating='$link_rating', link_rel='$link_rel',
-                        link_notes='$link_notes', link_rss = '$link_rss'
-                        WHERE link_id='$link_id'");
+                $wpdb->query( $wpdb->prepare("UPDATE $wpdb->links SET link_url = %s,
+                        link_name = %s, link_image = %s, link_target = %s, 
+                        link_visible = %s, link_description = %s, link_rating = %s, 
+                        link_rel = %s, link_notes = %s, link_rss = %s
+                        WHERE link_id = %s", $link_url, $link_name, $link_image, $link_target, $link_visible, $link_description, $link_rating, $link_rel, $link_notes, $link_rss, $link_id) );
         } else {
-                $wpdb->query("INSERT INTO $wpdb->links (link_url, link_name, link_image, link_target, link_description, link_visible, link_owner, link_rating, link_rel, link_notes, link_rss) VALUES('$link_url','$link_name', '$link_image', '$link_target', '$link_description', '$link_visible', '$link_owner', '$link_rating', '$link_rel', '$link_notes', '$link_rss')");
+                $wpdb->query( $wpdb->prepare("INSERT INTO $wpdb->links (link_url, link_name, link_image, link_target, link_description, link_visible, link_owner, link_rating, link_rel, link_notes, link_rss) VALUES(%s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s)", 
+                $link_url,$link_name, $link_image, $link_target, $link_description, $link_visible, $link_owner, $link_rating, $link_rel, $link_notes, $link_rss) );
                 $link_id = (int) $wpdb->insert_id;
         }
 

wp-admin/includes/template.php

@@ -892 +892 @@
 
 function parent_dropdown( $default = 0, $parent = 0, $level = 0 ) {
         global $wpdb, $post_ID;
-        $items = $wpdb->get_results( "SELECT ID, post_parent, post_title FROM $wpdb->posts WHERE post_parent = $parent AND post_type = 'page' ORDER BY menu_order" );
+        $items = $wpdb->get_results( $wpdb->prepare("SELECT ID, post_parent, post_title FROM $wpdb->posts WHERE post_parent = %d AND post_type = 'page' ORDER BY menu_order", $parent) );
 
         if ( $items ) {
                 foreach ( $items as $item ) {