Ticket #7993: 7993.2.diff

category-template.php

@@ -343 +343 @@
                 'selected' => 0, 'hierarchical' => 0,
                 'name' => 'cat', 'id' => '',
                 'class' => 'postform', 'depth' => 0,
-                'tab_index' => 0, 'taxonomy' => 'category',
+                'tab_index' => false, 'taxonomy' => 'category',
                 'hide_if_empty' => false
         );
 
@@ -365 +365 @@
         extract( $r );
 
         $tab_index_attribute = '';
-        if ( (int) $tab_index > 0 )
-                $tab_index_attribute = " tabindex=\"$tab_index\"";
+        if ( false !== $tab_index )
+                $tab_index_attribute = " tabindex=\"" . absint($tab_index) . "\"";
 
         $categories = get_terms( $taxonomy, $r );
         $name = esc_attr( $name );

post-template.php

@@ -712 +712 @@
                 'selected' => 0, 'echo' => 1,
                 'name' => 'page_id', 'id' => '',
                 'show_option_none' => '', 'show_option_no_change' => '',
-                'option_none_value' => ''
+                'option_none_value' => '', 'tab_index' => false
         );
 
         $r = wp_parse_args( $args, $defaults );
@@ -721 +721 @@
         $pages = get_pages($r);
         $output = '';
         $name = esc_attr($name);
+        
+        $tab_index_attribute = '';
+        if ( false !== $tab_index )
+                $tab_index_attribute = " tabindex=\"" . absint($tab_index) . "\"";
+
         // Back-compat with old system where both id and name were based on $name argument
         if ( empty($id) )
                 $id = $name;
 
         if ( ! empty($pages) ) {
-                $output = "<select name=\"$name\" id=\"$id\">\n";
+                $output = "<select name=\"$name\" id=\"$id\" $tab_index_attribute>\n";
                 if ( $show_option_no_change )
                         $output .= "\t<option value=\"-1\">$show_option_no_change</option>";
                 if ( $show_option_none )

user.php

@@ -590 +590 @@
                 'include' => '', 'exclude' => '', 'multi' => 0,
                 'show' => 'display_name', 'echo' => 1,
                 'selected' => 0, 'name' => 'user', 'class' => '', 'blog_id' => $GLOBALS['blog_id'],
-                'id' => '',
+                'id' => '', 'tab_index' => false
         );
 
         $defaults['selected'] = is_author() ? get_query_var( 'author' ) : 0;
@@ -621 +621 @@
         $query .= " ORDER BY $orderby $order";
 
         $users = $wpdb->get_results( $query );
+        
+        $tab_index_attribute = '';
+        if ( false !== $tab_index )
+                $tab_index_attribute = " tabindex=\"" . absint($tab_index) . "\"";
 
         $output = '';
         if ( !empty($users) ) {
@@ -630 +634 @@
                 else
                         $id = $id ? " id='" . esc_attr( $id ) . "'" : " id='$name'";
 
-                $output = "<select name='{$name}'{$id} class='$class'>\n";
+                $output = "<select name='{$name}'{$id} class='$class' $tab_index_attribute>\n";
 
                 if ( $show_option_all )
                         $output .= "\t<option value='0'>$show_option_all</option>\n";