Ticket #9393: 9393-media-fixes.diff

wp-admin/includes/media.php

@@ -430 +430 @@
                 return media_send_to_editor($html);
         }
 
-        return $errors;
+        return isset($errors) ? $errors : '';
 }
 
 /**
@@ -988 +988 @@
                         'label'      => __('File URL'),
                         'input'      => 'html',
                         'html'       => "<input type='text' class='urlfield' readonly='readonly' name='attachments[$post->ID][url]' value='" . attribute_escape($image_url) . "' /><br />",
-                        'value'      => $edit_post->post_url,
+                        'value'      => isset($edit_post->post_url) ? $edit_post->post_url : '',
                         'helps'      => __('Location of the uploaded file.'),
                 )
         );
@@ -1223 +1223 @@
         foreach ( $hidden_fields as $name => $value )
                 $item .= "\t<input type='hidden' name='$name' id='$name' value='" . attribute_escape( $value ) . "' />\n";
 
-        if ( $post->post_parent < 1 && (int) $_REQUEST['post_id'] ) {
+        if ( $post->post_parent < 1 && isset( $_REQUEST['post_id'] ) ) {
                 $parent = (int) $_REQUEST['post_id'];
                 $parent_name = "attachments[$attachment_id][post_parent]";
 

wp-admin/media.php

@@ -94 +94 @@
 
 <p class="submit">
 <input type="submit" class="button-primary" name="save" value="<?php _e('Update Media'); ?>" />
-<input type="hidden" name="post_id" id="post_id" value="<?php echo $post_id; ?>" />
+<input type="hidden" name="post_id" id="post_id" value="<?php echo isset($post_id) ? $post_id : ''; ?>" />
 <input type="hidden" name="attachment_id" id="attachment_id" value="<?php echo $att_id; ?>" />
 <input type="hidden" name="action" value="editattachment" />
 <?php wp_original_referer_field(true, 'previous'); ?>