Ticket #9402: validation_fixes.patch

wp-admin/includes/update.php

@@ -152 +152 @@
 
         $r = $current->response[ $file ];
 
-        $details_url = admin_url('plugin-install.php?tab=plugin-information&plugin=' . $r->slug . '&TB_iframe=true&width=600&height=800');
+        $details_url = admin_url('plugin-install.php?tab=plugin-information&plugin=' . $r->slug . '&TB_iframe=true&width=600&height=800');
 
         echo '<tr><td colspan="5" class="plugin-update">';
         if ( ! current_user_can('update_plugins') )

wp-admin/plugin-editor.php

@@ -50 +50 @@
                 if ( is_plugin_active($file) || isset($_POST['phperror']) ) {
                         if ( is_plugin_active($file) )
                                 deactivate_plugins($file, true);
-                        wp_redirect(add_query_arg('_wpnonce', wp_create_nonce('edit-plugin-test_' . $file), "plugin-editor.php?file=$file&liveupdate=1"));
+                        wp_redirect(add_query_arg('_wpnonce', wp_create_nonce('edit-plugin-test_' . $file), "plugin-editor.php?file=$file&liveupdate=1"));
                         exit;
                 }
-                wp_redirect("plugin-editor.php?file=$file&a=te");
+                wp_redirect("plugin-editor.php?file=$file&a=te");
         } else {
                 wp_redirect("plugin-editor.php?file=$file");
         }
@@ -74 +74 @@
                         wp_die( $error );
 
                 if ( ! is_plugin_active($file) )
-                        activate_plugin($file, "plugin-editor.php?file=$file&phperror=1");// we'll override this later if the plugin can be included without fatal error
+                        activate_plugin($file, "plugin-editor.php?file=$file&phperror=1");// we'll override this later if the plugin can be included without fatal error
 
-                wp_redirect("plugin-editor.php?file=$file&a=te");
+                wp_redirect("plugin-editor.php?file=$file&a=te");
                 exit;
         }
 
@@ -162 +162 @@
 
         <ul>
 <?php foreach($plugin_files as $plugin_file) : ?>
-                <li<?php echo $file == $plugin_file ? ' class="highlight"' : ''; ?>><a href="plugin-editor.php?file=<?php echo $plugin_file; ?>&plugin=<?php echo $plugin; ?>"><?php echo $plugin_file ?></a></li>
+                <li<?php echo $file == $plugin_file ? ' class="highlight"' : ''; ?>><a href="plugin-editor.php?file=<?php echo $plugin_file; ?>&amp;plugin=<?php echo $plugin; ?>"><?php echo $plugin_file ?></a></li>
 <?php endforeach; ?>
         </ul>
         </div>
@@ -175 +175 @@
                 <input type="hidden" name="plugin" value="<?php echo $plugin ?>" />
                 </div>
                 <?php if ( count( $functions ) ) : ?>
-                <div id="documentation"><label for="docs-list">Documentation:</label> <?php echo $docs_select ?> <input type="button" class="button" value=" <?php _e( 'Lookup' ) ?> " onclick="if ( '' != jQuery('#docs-list').val() ) { window.open( 'http://api.wordpress.org/core/handbook/1.0/?function=' + escape( jQuery( '#docs-list' ).val() ) + '&locale=<?php echo urlencode( get_locale() ) ?>&version=<?php echo urlencode( $wp_version ) ?>&redirect=true'); }" /></div>
+                <div id="documentation"><label for="docs-list">Documentation:</label> <?php echo $docs_select ?> <input type="button" class="button" value=" <?php _e( 'Lookup' ) ?> " onclick="if ( '' != jQuery('#docs-list').val() ) { window.open( 'http://api.wordpress.org/core/handbook/1.0/?function=' + escape( jQuery( '#docs-list' ).val() ) + '&amp;locale=<?php echo urlencode( get_locale() ) ?>&amp;version=<?php echo urlencode( $wp_version ) ?>&amp;redirect=true'); }" /></div>
                 <?php endif; ?>
 <?php if ( is_writeable($real_file) ) : ?>
         <?php if ( in_array($file, (array) get_option('active_plugins')) ) { ?>

wp-admin/theme-editor.php

@@ -206 +206 @@
                 <div id="documentation">
                 <label for="docs-list"><?php _e('Documentation:') ?></label>
                 <?php echo $docs_select; ?>
-                <input type="button" class="button" value=" <?php _e( 'Lookup' ); ?> " onclick="if ( '' != jQuery('#docs-list').val() ) { window.open( 'http://api.wordpress.org/core/handbook/1.0/?function=' + escape( jQuery( '#docs-list' ).val() ) + '&locale=<?php echo urlencode( get_locale() ) ?>&version=<?php echo urlencode( $wp_version ) ?>&redirect=true'); }" />
+                <input type="button" class="button" value=" <?php _e( 'Lookup' ); ?> " onclick="if ( '' != jQuery('#docs-list').val() ) { window.open( 'http://api.wordpress.org/core/handbook/1.0/?function=' + escape( jQuery( '#docs-list' ).val() ) + '&amp;locale=<?php echo urlencode( get_locale() ) ?>&amp;version=<?php echo urlencode( $wp_version ) ?>&amp;redirect=true'); }" />
                 </div>
         <?php } ?>