Changeset 10070

Timestamp:

12/05/2008 07:19:24 PM (17 years ago)

Author:

ryan

Message:

post_parent dropdown fixes. get_pages() cache fix to eliminate duplicate queries.

Location:

trunk

Files:

• wp-admin/includes/template.php (modified) (1 diff)
• wp-includes/classes.php (modified) (1 diff)
• wp-includes/post-template.php (modified) (1 diff)
• wp-includes/post.php (modified) (1 diff)

trunk/wp-admin/includes/template.php

@@ -1051 +1051 @@
     if ( $bulk )
         $dropdown_args['show_option_no_change'] =  __('- No Change -');
+    wp_dropdown_pages($dropdown_args);
 ?>
-                <?php wp_dropdown_pages($dropdown_args); ?>
         </label>
 

trunk/wp-includes/classes.php

@@ -1234 +1234 @@
         $pad = str_repeat(' ', $depth * 3);
 
-        $output .= "\t<option value=\"$page->ID\"";
+        $output .= "\t<option class=\"level-$depth\" value=\"$page->ID\"";
         if ( $page->ID == $args['selected'] )
             $output .= ' selected="selected"';

trunk/wp-includes/post-template.php

@@ -566 +566 @@
 
     if ( ! empty($pages) ) {
-        $output = "<select name='$name' id='$name'>\n";
+        $output = "<select name=\"$name\" id=\"$name\">\n";
         if ( $show_option_no_change )
-            $output .= "\t<option value='-1'>$show_option_no_change</option>";
+            $output .= "\t<option value=\"-1\">$show_option_no_change</option>";
         if ( $show_option_none )
-            $output .= "\t<option value='$option_none_value'>$show_option_none</option>\n";
+            $output .= "\t<option value=\"$option_none_value\">$show_option_none</option>\n";
         $output .= walk_page_dropdown_tree($pages, $depth, $r);
         $output .= "</select>\n";

trunk/wp-includes/post.php

@@ -2066 +2066 @@
     extract( $r, EXTR_SKIP );
 
-    $key = md5( serialize( $r ) );
+    $key = md5( serialize( compact(array_keys($defaults)) ) );
     if ( $cache = wp_cache_get( 'get_pages', 'posts' ) ) {
         if ( isset( $cache[ $key ] ) ) {