Changeset 10107

Timestamp:

12/07/2008 09:04:38 AM (17 years ago)

Author:

azaozz

Message:

Don't select hidden rows' checkboxes when selecting all, fixes #8520

Location:

trunk

Files:

• wp-admin/js/common.js (modified) (2 diffs)
• wp-includes/script-loader.php (modified) (1 diff)

trunk/wp-admin/js/common.js

@@ -193 +193 @@
             var first = checks.index( lastClicked );
             var last = checks.index( this );
+            var checked = $(this).attr('checked');
             if ( 0 < first && 0 < last && first != last ) {
-                checks.slice( first, last ).attr( 'checked', $( this ).is( ':checked' ) ? 'checked' : '' );
+                checks.slice( first, last ).attr( 'checked', function(){
+                    if ( $(this).parents('tr').is(':visible') )
+                        return checked ? 'checked' : '';
+
+                    return '';
+                });
             }
         }
@@ -206 +212 @@
         var toggle = e.shiftKey || toggleWithKeyboard;
         $(this).parents( 'form:first' ).find( 'table tbody:visible').find( '.check-column :checkbox' ).attr( 'checked', function() {
+            if ( $(this).parents('tr').is(':hidden') )
+                return '';
             if ( toggle )
                 return $(this).attr( 'checked' ) ? '' : 'checked';

trunk/wp-includes/script-loader.php

@@ -42 +42 @@
     $scripts->default_version = get_bloginfo( 'version' );
 
-    $scripts->add( 'common', '/wp-admin/js/common.js', array('jquery', 'hoverIntent'), '20081206' );
+    $scripts->add( 'common', '/wp-admin/js/common.js', array('jquery', 'hoverIntent'), '20081206b' );
     $scripts->add( 'sack', '/wp-includes/js/tw-sack.js', false, '1.6.1' );