Changeset 10801

Timestamp:

03/17/2009 02:58:15 AM (17 years ago)

Author:

ryan

Message:

Move submit check into WP_Widget

Location:

trunk/wp-includes

Files:

• default-widgets.php (modified) (5 diffs)
• widgets.php (modified) (1 diff)

trunk/wp-includes/default-widgets.php

@@ -45 +45 @@
     
     function update( $new_instance, $old_instance ) {
-        if ( !isset($new_instance['submit']) ) // user clicked cancel?
-            return false;
-
         $instance = $old_instance;
         $instance['title'] = strip_tags($new_instance['title']);
@@ -120 +117 @@
     
     function update( $new_instance, $old_instance ) {
-        if( !isset($new_instance['submit']) ) // user clicked cancel?
-            return false;
-
         $new_instance = (array) $new_instance;
         $instance = array( 'images' => 0, 'name' => 0, 'description' => 0, 'rating' => 0);
@@ -213 +207 @@
 
     function update( $new_instance, $old_instance ) {
-        if ( !isset($new_instance['submit']) ) // user clicked cancel?
-            return false;
-
         $instance = $old_instance;
         $new_instance = wp_parse_args( (array) $new_instance, array( 'title' => '', 'count' => 0, 'dropdown' => '') );
@@ -276 +267 @@
 
     function update( $new_instance, $old_instance ) {
-        if ( !isset($new_instance['submit']) ) // user clicked cancel?
-            return false;
-
         $instance = $old_instance;
         $instance['title'] = strip_tags($new_instance['title']);
@@ -319 +307 @@
 
     function update( $new_instance, $old_instance ) {
-        if ( !isset($new_instance['submit']) ) // user clicked cancel?
-            return false;
-
         $instance = $old_instance;
         $instance['title'] = strip_tags($new_instance['title']);

trunk/wp-includes/widgets.php

@@ -214 +214 @@
             }
 
-            foreach( (array) $_POST['widget-' . $this->id_base] as $number => $new_instance ) {
+            foreach ( (array) $_POST['widget-' . $this->id_base] as $number => $new_instance ) {
                 $new_instance = stripslashes_deep($new_instance);
                 $this->_set($number);
+
+                if ( !isset($new_instance['submit']) )
+                    continue;
+
                 if ( isset($all_instances[$number]) )
                     $instance = $this->update($new_instance, $all_instances[$number]);