Changeset 11098

Timestamp:

04/27/2009 04:17:24 PM (12 years ago)

Author:

ryan

Message:

Eliminate preg_replace with /e. Props tbaboon. fixes #8689

Location:

trunk/wp-includes

Files:

• class-phpmailer.php (modified) (2 diffs)
• formatting.php (modified) (2 diffs)

trunk/wp-includes/class-phpmailer.php

@@ -1404 +1404 @@
 
   /**
+   * Callback for converting to "=XX".
+   * @access private
+   * @return string
+   */
+  function EncodeQ_callback ($matches) {
+    return "=".sprintf("%02X", ord($matches[1]));
+  }
+
+  /**
    * Encode string to q encoding.
    * @access private
@@ -1414 +1423 @@
     switch (strtolower($position)) {
       case 'phrase':
-        $encoded = preg_replace("/([^A-Za-z0-9!*+\/ -])/e", "'='.sprintf('%02X', ord('\\1'))", $encoded);
+        $encoded = preg_replace_callback("/([^A-Za-z0-9!*+\/ -])/",
+                                         "EncodeQ_callback", $encoded);
         break;
       case 'comment':
-        $encoded = preg_replace("/([\(\)\"])/e", "'='.sprintf('%02X', ord('\\1'))", $encoded);
+        $encoded = preg_replace_callback("/([\(\)\"])/",
+                                         "EncodeQ_callback", $encoded);
+        break;
       case 'text':
       default:
         /* Replace every high ascii, control =, ? and _ characters */
-        $encoded = preg_replace('/([\000-\011\013\014\016-\037\075\077\137\177-\377])/e',
-              "'='.sprintf('%02X', ord('\\1'))", $encoded);
+        $encoded = preg_replace_callback('/([\000-\011\013\014\016-\037\075\077\137\177-\377])/',
+                                         "EncodeQ_callback", $encoded);
         break;
     }

trunk/wp-includes/formatting.php

@@ -774 +774 @@
 
 /**
+ * Callback used to change %uXXXX to &#YYY; syntax
+ *
+ * @since 2.8?
+ *
+ * @param array $matches Single Match
+ * @return string An HTML entity
+ */
+function funky_javascript_callback($matches) {
+    return "&#".base_convert($matches[1],16,10).";";
+}
+
+/**
  * Fixes javascript bugs in browsers.
  *
@@ -789 +801 @@
     global $is_macIE, $is_winIE;
 
-    /** @todo use preg_replace_callback() instead */
     if ( $is_winIE || $is_macIE )
-        $text =  preg_replace("/\%u([0-9A-F]{4,4})/e",  "'&#'.base_convert('\\1',16,10).';'", $text);
+        $text =  preg_replace_callback("/\%u([0-9A-F]{4,4})/",
+                           "funky_javascript_callback",
+                           $text);
 
     return $text;