Changeset 11204 for trunk/wp-admin/includes/plugin-install.php

Timestamp:

05/05/2009 07:43:53 PM (16 years ago)

Author:

markjaquith

Message:

_a(), _ea(), _xa(), attr() are now esc_attr(), esc_attr_e(), esc_attr_x(), esc_attr() -- still short, but less cryptic. see #9650

File:

• trunk/wp-admin/includes/plugin-install.php (modified) (7 diffs)

trunk/wp-admin/includes/plugin-install.php

@@ -163 +163 @@
             <option value="tag"<?php selected('tag', $type) ?>><?php _x('Tag', 'Plugin Installer') ?></option>
         </select>
-        <input type="text" name="s" value="<?php echo attr($term) ?>" />
+        <input type="text" name="s" value="<?php echo esc_attr($term) ?>" />
         <label class="invisible" for="plugin-search-input"><?php _e('Search Plugins'); ?></label>
-        <input type="submit" id="plugin-search-input" name="search" value="<?php _ea('Search Plugins') ?>" class="button" />
+        <input type="submit" id="plugin-search-input" name="search" value="<?php esc_attr_e('Search Plugins') ?>" class="button" />
     </form><?php
 }
@@ -214 +214 @@
         <label class="invisible" for="pluginzip"><?php _e('Plugin zip file'); ?></label>
         <input type="file" id="pluginzip" name="pluginzip" />
-        <input type="submit" class="button" value="<?php _ea('Install Now') ?>" />
+        <input type="submit" class="button" value="<?php esc_attr_e('Install Now') ?>" />
     </form>
 <?php
@@ -337 +337 @@
 
                 if( isset($plugin['homepage']) )
-                    $title = '<a target="_blank" href="' . attr($plugin['homepage']) . '">' . $title . '</a>';
+                    $title = '<a target="_blank" href="' . esc_attr($plugin['homepage']) . '">' . $title . '</a>';
 
                 $action_links = array();
                 $action_links[] = '<a href="' . admin_url('plugin-install.php?tab=plugin-information&amp;plugin=' . $plugin['slug'] .
                                     '&amp;TB_iframe=true&amp;width=600&amp;height=800') . '" class="thickbox onclick" title="' .
-                                    attr($name) . '">' . __('Install') . '</a>';
+                                    esc_attr($name) . '">' . __('Install') . '</a>';
 
                 $action_links = apply_filters('plugin_install_action_links', $action_links, $plugin);
@@ -351 +351 @@
                 <td class="vers">
                     <div class="star-holder" title="<?php printf(_n('(based on %s rating)', '(based on %s ratings)', $plugin['num_ratings']), number_format_i18n($plugin['num_ratings'])) ?>">
-                        <div class="star star-rating" style="width: <?php echo attr($plugin['rating']) ?>px"></div>
+                        <div class="star star-rating" style="width: <?php echo esc_attr($plugin['rating']) ?>px"></div>
                         <div class="star star5"><img src="<?php echo admin_url('images/star.gif'); ?>" alt="<?php _e('5 stars') ?>" /></div>
                         <div class="star star4"><img src="<?php echo admin_url('images/star.gif'); ?>" alt="<?php _e('4 stars') ?>" /></div>
@@ -419 +419 @@
         $href = add_query_arg( array('tab' => $tab, 'section' => $section_name) );
         $href = clean_url($href);
-        $san_title = attr(sanitize_title_with_dashes($title));
+        $san_title = esc_attr(sanitize_title_with_dashes($title));
         echo "\t<li><a name='$san_title' target='' href='$href'$class>$title</a></li>\n";
     }
@@ -508 +508 @@
         <h2><?php _e('Average Rating') ?></h2>
         <div class="star-holder" title="<?php printf(_n('(based on %s rating)', '(based on %s ratings)', $api->num_ratings), number_format_i18n($api->num_ratings)); ?>">
-            <div class="star star-rating" style="width: <?php echo attr($api->rating) ?>px"></div>
+            <div class="star star-rating" style="width: <?php echo esc_attr($api->rating) ?>px"></div>
             <div class="star star5"><img src="<?php echo admin_url('images/star.gif'); ?>" alt="<?php _e('5 stars') ?>" /></div>
             <div class="star star4"><img src="<?php echo admin_url('images/star.gif'); ?>" alt="<?php _e('4 stars') ?>" /></div>
@@ -533 +533 @@
             $content = links_add_target($content, '_blank');
 
-            $san_title = attr(sanitize_title_with_dashes($title));
+            $san_title = esc_attr(sanitize_title_with_dashes($title));
 
             $display = ( $section_name == $section ) ? 'block' : 'none';