Changeset 11306

Timestamp:

05/12/2009 05:11:57 PM (14 years ago)

Author:

ryan

Message:

Use IDs instead of slugs in CSS classes ro avoid invalid class names. Props hakre. fixes #8446

Location:

trunk/wp-includes

Files:

• comment-template.php (modified) (1 diff)
• post-template.php (modified) (5 diffs)

trunk/wp-includes/comment-template.php

@@ -295 +295 @@
         // For all registered users, 'byuser'
         $classes[] = 'byuser';
-        $classes[] = 'comment-author-' . $user->user_nicename;
+        $classes[] = 'comment-author-' . $user->user_id;
         // For comment authors who are the author of the post
         if ( $post = get_post($post_id) ) {

trunk/wp-includes/post-template.php

@@ -312 +312 @@
 
     $classes = array();
-
+    
+    $classes[] = 'post-' . $post->ID;
     $classes[] = $post->post_type;
 
@@ -324 +325 @@
     // Categories
     foreach ( (array) get_the_category($post->ID) as $cat ) {
-        if ( empty($cat->slug ) )
+        if ( empty($cat->cat_ID ) )
             continue;
-        $classes[] = 'category-' . $cat->slug;
+        $classes[] = 'category-' . $cat->cat_ID;
     }
 
     // Tags
     foreach ( (array) get_the_tags($post->ID) as $tag ) {
-        if ( empty($tag->slug ) )
+        if ( empty($tag->term_id ) )
             continue;
-        $classes[] = 'tag-' . $tag->slug;
+        $classes[] = 'tag-' . $tag->term_id;
     }
 
@@ -400 +401 @@
             $mime_type = get_post_mime_type();
             $mime_prefix = array( 'application/', 'image/', 'text/', 'audio/', 'video/', 'music/' );
-            $classes[] = 'attachmentid-' . $postID . ' attachment-' . str_replace( $mime_prefix, "", "$mime_type" );
+            $classes[] = 'attachmentid-' . $postID;
+            $classes[] = 'attachment-' . str_replace($mime_prefix, '', $mime_type);
         }
     } elseif ( is_archive() ) {
@@ -406 +408 @@
             $author = $wp_query->get_queried_object();
             $classes[] = 'author';
-            $classes[] = 'author-' . $author->user_nicename;
+            $classes[] = 'author-' . $author->user_id;
         } elseif ( is_category() ) {
             $cat = $wp_query->get_queried_object();
             $classes[] = 'category';
-            $classes[] = 'category-' . $cat->slug;
+            $classes[] = 'category-' . $cat->cat_ID;
         } elseif ( is_tag() ) {
             $tags = $wp_query->get_queried_object();
             $classes[] = 'tag';
-            $classes[] = 'tag-' . $tags->slug;
+            $classes[] = 'tag-' . $tags->term_id;
         }
     } elseif ( is_page() ) {
@@ -430 +432 @@
 
         if ( $wp_query->post->post_parent )
-            $classes[] = 'page-child parent-pageid-' . $wp_query->post->post_parent;
+            $classes[] = 'page-child';
+            $classes[] = 'parent-pageid-' . $wp_query->post->post_parent;
 
         if ( is_page_template() )
-            $classes[] = 'page-template page-template-' . str_replace( '.php', '-php', get_post_meta( $pageID, '_wp_page_template', true ) );
+            $classes[] = 'page-template';
+            $classes[] = 'page-template-' . str_replace( '.php', '-php', get_post_meta( $pageID, '_wp_page_template', true ) );
     } elseif ( is_search() ) {
         if ( !empty($wp_query->posts) )