Changeset 11668

Timestamp:

06/29/2009 08:24:04 PM (15 years ago)

Author:

ryan

Message:

Proper permissions for newly created files. Props azaozz. fixes #10170 for 2.8.1

File:

• branches/2.8/wp-admin/includes/class-wp-filesystem-direct.php (modified) (3 diffs)

branches/2.8/wp-admin/includes/class-wp-filesystem-direct.php

@@ -21 +21 @@
         $this->method = 'direct';
         $this->errors = new WP_Error();
-        $this->permission = umask();
     }
     function connect() {
@@ -65 +64 @@
     }
     function chmod($file, $mode = false, $recursive = false) {
-        if ( ! $mode )
-            $mode = $this->permission;
         if ( ! $this->exists($file) )
             return false;
-        if ( ! $recursive )
-            return @chmod($file,$mode);
+
+        if ( ! $mode ) {
+            if ( $this->permission )
+                $mode = $this->permission;
+            elseif ( $this->is_file($file) )
+                $mode = FS_CHMOD_FILE;
+            elseif ( $this->is_dir($file) )
+                $mode = FS_CHMOD_DIR;
+            else
+                return false;   
+        }
+
+        if ( ! $recursive )
+            return @chmod($file, $mode);
         if ( ! $this->is_dir($file) )
             return @chmod($file, $mode);
@@ -198 +207 @@
 
     function mkdir($path, $chmod = false, $chown = false, $chgrp = false){
-        if ( ! $chmod)
-            $chmod = $this->permission;
-
-        if ( ! @mkdir($path, $chmod) )
-            return false;
+        if ( ! @mkdir($path) )
+            return false;
+        $this->chmod($path, $chmod);
         if ( $chown )
             $this->chown($path, $chown);