Changeset 11709 for trunk/wp-admin/includes/template.php

Timestamp:

07/11/2009 09:17:09 AM (16 years ago)

Author:

westi

Message:

Call wp_dropdown_users() with echo=0 when outputting the quickedit and bulkedit forms so as to remove the need for output buffering. Fixes #10062 props johnbillion.

File:

• trunk/wp-admin/includes/template.php (modified) (1 diff)

trunk/wp-admin/includes/template.php

@@ -1056 +1056 @@
 <?php endif; // $bulk
 
-        ob_start();
         $authors = get_editable_user_ids( $current_user->id, true, $type ); // TODO: ROLE SYSTEM
         if ( $authors && count( $authors ) > 1 ) :
-            $users_opt = array('include' => $authors, 'name' => 'post_author', 'class'=> 'authors', 'multi' => 1);
+            $users_opt = array('include' => $authors, 'name' => 'post_author', 'class'=> 'authors', 'multi' => 1, 'echo' => 0);
             if ( $bulk )
                 $users_opt['show_option_none'] = __('- No Change -');
-?>
-        <label>
-            <span class="title"><?php _e( 'Author' ); ?></span>
-            <?php wp_dropdown_users( $users_opt ); ?>
-        </label>
-
-<?php
+
+        $authors_dropdown  = '<label>';
+        $authors_dropdown .= '<span class="title">' . __( 'Author' ) . '</span>';
+        $authors_dropdown .= wp_dropdown_users( $users_opt );
+        $authors_dropdown .= '</label>';
+
         endif; // authors
-        $authors_dropdown = ob_get_clean();
 ?>