Changeset 11957

Timestamp:

09/21/2009 09:43:41 PM (16 years ago)

Author:

westi

Message:

Move theme preview away from using create_function and to predefined functions. See #10729.

File:

• trunk/wp-includes/theme.php (modified) (3 diffs)

trunk/wp-includes/theme.php

@@ -887 +887 @@
         return;
 
-    add_filter( 'template', create_function('', "return '{$_GET['template']}';") );
+    add_filter( 'template', '_preview_theme_template_filter' );
 
     if ( isset($_GET['stylesheet']) ) {
@@ -893 +893 @@
         if ( validate_file($_GET['stylesheet']) )
             return;
-        add_filter( 'stylesheet', create_function('', "return '{$_GET['stylesheet']}';") );
+        add_filter( 'stylesheet', '_preview_theme_stylesheet_filter' );
     }
 
@@ -902 +902 @@
 }
 add_action('setup_theme', 'preview_theme');
+
+/**
+ * Private function to modify the current template when previewing a theme
+ * 
+ * @return string
+ */
+function _preview_theme_template_filter() {
+    return isset($_GET['template']) ? $_GET['template'] : '';
+}
+
+/**
+ * Private function to modify the current stylesheet when previewing a theme
+ * 
+ * @return string
+ */
+function _preview_theme_stylesheet_filter() {
+    return isset($_GET['stylesheet']) ? $_GET['stylesheet'] : '';
+}
 
 /**