Changeset 11964 for trunk/wp-admin/import/blogger.php

Timestamp:

09/23/2009 10:03:39 PM (16 years ago)

Author:

ryan

Message:

Use hard-coded functions instead of create_function() in importers. Props mdawaffe. fixes #10836

File:

• trunk/wp-admin/import/blogger.php (modified) (5 diffs)

trunk/wp-admin/import/blogger.php

@@ -530 +530 @@
     }
 
+    function _normalize_tag( $matches ) {
+        return '<' . strtolower( $match[1] );
+    }
+
     function import_post( $entry ) {
         global $importing_blog;
@@ -552 +556 @@
 
         // Clean up content
-        $post_content = preg_replace_callback('|<(/?[A-Z]+)|', create_function('$match', 'return "<" . strtolower($match[1]);'), $post_content);
+        $post_content = preg_replace_callback('|<(/?[A-Z]+)|', array( &$this, '_normalize_tag' ), $post_content);
         $post_content = str_replace('<br>', '<br />', $post_content);
         $post_content = str_replace('<hr>', '<hr />', $post_content);
@@ -605 +609 @@
 
         // Clean up content
-        $comment_content = preg_replace_callback('|<(/?[A-Z]+)|', create_function('$match', 'return "<" . strtolower($match[1]);'), $comment_content);
+        $comment_content = preg_replace_callback('|<(/?[A-Z]+)|', array( &$this, '_normalize_tag' ), $comment_content);
         $comment_content = str_replace('<br>', '<br />', $comment_content);
         $comment_content = str_replace('<hr>', '<hr />', $comment_content);
@@ -906 +910 @@
 
     function AtomParser() {
-
         $this->entry = new AtomEntry();
-        $this->map_attrs_func = create_function('$k,$v', 'return "$k=\"$v\"";');
-        $this->map_xmlns_func = create_function('$p,$n', '$xd = "xmlns"; if(strlen($n[0])>0) $xd .= ":{$n[0]}"; return "{$xd}=\"{$n[1]}\"";');
+    }
+
+    function _map_attrs_func( $k, $v ) {
+        return "$k=\"$v\"";
+    }
+
+    function _map_xmlns_func( $p, $n ) {
+        $xd = "xmlns";
+        if ( strlen( $n[0] ) > 0 )
+            $xd .= ":{$n[0]}";
+
+        return "{$xd}=\"{$n[1]}\"";
     }
 
@@ -951 +964 @@
                 $attrs_prefix[$this->ns_to_prefix($key)] = $this->xml_escape($value);
             }
-            $attrs_str = join(' ', array_map($this->map_attrs_func, array_keys($attrs_prefix), array_values($attrs_prefix)));
+            $attrs_str = join(' ', array_map( array( &$this, '_map_attrs_func' ), array_keys($attrs_prefix), array_values($attrs_prefix)));
             if(strlen($attrs_str) > 0) {
                 $attrs_str = " " . $attrs_str;
             }
 
-            $xmlns_str = join(' ', array_map($this->map_xmlns_func, array_keys($this->ns_contexts[0]), array_values($this->ns_contexts[0])));
+            $xmlns_str = join(' ', array_map( array( &$this, '_map_xmlns_func' ), array_keys($this->ns_contexts[0]), array_values($this->ns_contexts[0])));
             if(strlen($xmlns_str) > 0) {
                 $xmlns_str = " " . $xmlns_str;