Changeset 12111

Timestamp:

10/26/2009 06:02:44 PM (16 years ago)

Author:

markjaquith

Message:

thumbnail JS fixes. props scribu. see #10928

Location:

trunk

Files:

• wp-admin/js/set-post-thumbnail.dev.js (modified) (1 diff)
• wp-admin/js/set-post-thumbnail.js (modified) (1 diff)
• wp-includes/script-loader.php (modified) (1 diff)

trunk/wp-admin/js/set-post-thumbnail.dev.js

@@ -1 +1 @@
 function WPSetAsThumbnail(id){
-    jQuery('#media-item-' + id + ' > a.wp-post-thumbnail').text( setPostThumbnailL10n.saving ).attr('href', '#');
+    var $link = jQuery('#media-item-' + id + ' a.wp-post-thumbnail');
+
+    $link.text( setPostThumbnailL10n.saving );
     jQuery.post(ajaxurl, {
         action:"set-post-thumbnail", post_id: post_id, thumbnail_id: id, cookie: encodeURIComponent(document.cookie)
     }, function(str){
         var win = window.dialogArguments || opener || parent || top;
+        $link.text( setPostThumbnailL10n.setThumbnail );
         if ( str == '0' ) {
             alert( setPostThumbnailL10n.error );
         } else {
-            jQuery('a.wp-post-thumbnail').text( setPostThumbnailL10n.setThumbnail );
-            jQuery('#media-item-' + id + ' > a.wp-post-thumbnail').hide();
+            jQuery('a.wp-post-thumbnail').show();
+            $link.hide();
             win.WPSetThumbnailID(id);
             win.WPSetThumbnailHTML(str);

trunk/wp-admin/js/set-post-thumbnail.js

@@ -1 @@
-function WPSetAsThumbnail(id){jQuery("#media-item-"+id+" > a.wp-post-thumbnail").text(setPostThumbnailL10n.saving).attr("href","#");jQuery.post(ajaxurl,{action:"set-post-thumbnail",post_id:post_id,thumbnail_id:id,cookie:encodeURIComponent(document.cookie)},function(str){var win=window.dialogArguments||opener||parent||top;if(str=="0"){alert(setPostThumbnailL10n.error)}else{jQuery("a.wp-post-thumbnail").text(setPostThumbnailL10n.setThumbnail);jQuery("#media-item-"+id+" > a.wp-post-thumbnail").hide();win.WPSetThumbnailID(id);win.WPSetThumbnailHTML(str)}})};
+function WPSetAsThumbnail(id){var $link=jQuery("#media-item-"+id+" a.wp-post-thumbnail");$link.text(setPostThumbnailL10n.saving);jQuery.post(ajaxurl,{action:"set-post-thumbnail",post_id:post_id,thumbnail_id:id,cookie:encodeURIComponent(document.cookie)},function(str){var win=window.dialogArguments||opener||parent||top;$link.text(setPostThumbnailL10n.setThumbnail);if(str=="0"){alert(setPostThumbnailL10n.error)}else{jQuery("a.wp-post-thumbnail").show();$link.hide();win.WPSetThumbnailID(id);win.WPSetThumbnailHTML(str)}})};

trunk/wp-includes/script-loader.php

@@ -373 +373 @@
         $scripts->add_data( 'image-edit', 'group', 1 );
 
-        $scripts->add( 'set-post-thumbnail', "/wp-admin/js/set-post-thumbnail$suffix.js", array( 'jquery' ), '20091015' );
+        $scripts->add( 'set-post-thumbnail', "/wp-admin/js/set-post-thumbnail$suffix.js", array( 'jquery' ), '20091021' );
         $scripts->add_data( 'set-post-thumbnail', 'group', 1 );
         $scripts->localize( 'set-post-thumbnail', 'setPostThumbnailL10n', array(
-            'setThumbnail' => __( 'Use for thumbnail' ),
+            'setThumbnail' => __( 'Use as thumbnail' ),
             'saving' => __( 'Saving...' ),
             'error' => __( 'Could not set that as the thumbnail image. Try a different attachment.' )