Changeset 12198

Timestamp:

11/17/2009 07:25:01 PM (16 years ago)

Author:

ryan

Message:

Use preg_replace_callback to eliminate eval. Props BenBE1987. fixes #10896

File:

• trunk/wp-admin/includes/post.php (modified) (3 diffs)

trunk/wp-admin/includes/post.php

@@ -714 +714 @@
  */
 function _fix_attachment_links( $post_ID ) {
+    global $_fix_attachment_link_id;
 
     $post = & get_post( $post_ID, ARRAY_A );
@@ -741 +742 @@
 
         $post_search[$i] = $anchor;
-        $post_replace[$i] = preg_replace( "#href=(\"|')[^'\"]*\\1#e", "stripslashes( 'href=\\1' ).get_attachment_link( $id ).stripslashes( '\\1' )", $anchor );
+         $_fix_attachment_link_id = $id;
+        $post_replace[$i] = preg_replace_callback( "#href=(\"|')[^'\"]*\\1#", '_fix_attachment_links_replace_cb', $anchor );
         ++$i;
     }
@@ -751 +753 @@
 
     return wp_update_post( $post);
+}
+
+function _fix_attachment_links_replace_cb($match) {
+        global $_fix_attachment_link_id;
+        return stripslashes( 'href='.$m[1] ).get_attachment_link( $_fix_attachment_link_id ).stripslashes( $m[1] );
 }