Changeset 12355

Timestamp:

12/10/09 08:03:26 (4 years ago)

Author:

markjaquith

Message:

Provide visual feedback for "Use as thumbnail" when clicked immediately after uploading the image. fixes #11140

Location:

trunk

Files:

• wp-admin/includes/media.php (modified) (1 diff)
• wp-admin/js/set-post-thumbnail.dev.js (modified) (1 diff)
• wp-admin/js/set-post-thumbnail.js (modified) (1 diff)
• wp-includes/script-loader.php (modified) (1 diff)

trunk/wp-admin/includes/media.php

@@ -1246 +1246 @@
         $calling_post_id = $post->post_parent;
     if ( 'image' == $type && $calling_post_id && current_theme_supports( 'post-thumbnails', get_post_type( $calling_post_id ) ) && get_post_thumbnail_id( $calling_post_id ) != $attachment_id )
-        $thumbnail = "<a class='wp-post-thumbnail' href='#' onclick='WPSetAsThumbnail(\"$attachment_id\");return false;'>" . esc_html__( "Use as thumbnail" ) . "</a>";
+        $thumbnail = "<a class='wp-post-thumbnail' id='wp-post-thumbnail-" . $attachment_id . "' href='#' onclick='WPSetAsThumbnail(\"$attachment_id\");return false;'>" . esc_html__( "Use as thumbnail" ) . "</a>";
 
     if ( ( $send || $thumbnail || $delete ) && !isset($form_fields['buttons']) )

trunk/wp-admin/js/set-post-thumbnail.dev.js

@@ -1 +1 @@
 function WPSetAsThumbnail(id){
-    var $link = jQuery('#media-item-' + id + ' a.wp-post-thumbnail');
+    var $link = jQuery('a#wp-post-thumbnail-' + id);
 
     $link.text( setPostThumbnailL10n.saving );

trunk/wp-admin/js/set-post-thumbnail.js

@@ -1 @@
-function WPSetAsThumbnail(id){var $link=jQuery("#media-item-"+id+" a.wp-post-thumbnail");$link.text(setPostThumbnailL10n.saving);jQuery.post(ajaxurl,{action:"set-post-thumbnail",post_id:post_id,thumbnail_id:id,cookie:encodeURIComponent(document.cookie)},function(str){var win=window.dialogArguments||opener||parent||top;$link.text(setPostThumbnailL10n.setThumbnail);if(str=="0"){alert(setPostThumbnailL10n.error)}else{jQuery("a.wp-post-thumbnail").show();$link.text(setPostThumbnailL10n.done);$link.fadeOut(2000);win.WPSetThumbnailID(id);win.WPSetThumbnailHTML(str)}})};
+function WPSetAsThumbnail(id){var $link=jQuery("a#wp-post-thumbnail-"+id);$link.text(setPostThumbnailL10n.saving);jQuery.post(ajaxurl,{action:"set-post-thumbnail",post_id:post_id,thumbnail_id:id,cookie:encodeURIComponent(document.cookie)},function(str){var win=window.dialogArguments||opener||parent||top;$link.text(setPostThumbnailL10n.setThumbnail);if(str=="0"){alert(setPostThumbnailL10n.error)}else{jQuery("a.wp-post-thumbnail").show();$link.text(setPostThumbnailL10n.done);$link.fadeOut(2000);win.WPSetThumbnailID(id);win.WPSetThumbnailHTML(str)}})};

trunk/wp-includes/script-loader.php

@@ -383 +383 @@
         $scripts->add_data( 'image-edit', 'group', 1 );
 
-        $scripts->add( 'set-post-thumbnail', "/wp-admin/js/set-post-thumbnail$suffix.js", array( 'jquery' ), '20091210' );
+        $scripts->add( 'set-post-thumbnail', "/wp-admin/js/set-post-thumbnail$suffix.js", array( 'jquery' ), '20091210b' );
         $scripts->add_data( 'set-post-thumbnail', 'group', 1 );
         $scripts->localize( 'set-post-thumbnail', 'setPostThumbnailL10n', array(