Changeset 1238 in tests

Timestamp:

03/06/2013 05:41:20 PM (12 years ago)

Author:

joehoyle

Message:

better test for wp_unique_filename() fixes #23699

File:

• trunk/tests/functions.php (modified) (1 diff)

trunk/tests/functions.php

@@ -99 +99 @@
     }
 
-
     function test_wp_unique_filename() {
-        /* this test requires:
-           - that you have dir + file 'data/images/test-image.png',
-           - and that this dir is writeable
-           - there is an image 'test-image.png' that will be used to test unique filenames
-
-           NB: there is a hardcoded dependency that the testing file is '.png'; however,
-               this limitation is arbitary, so change it if you like.
-        */
+        
         $testdir = DIR_TESTDATA . '/images/';
-        $testimg = 'test-image.png';
-        $this->assertTrue( file_exists($testdir) );
-        $this->assertTrue( is_writable($testdir) );
-        $this->assertTrue( file_exists($testdir . $testimg) );
-
-        $cases = array(
-            // null case
-            'null' . $testimg,
-
-            // edge cases: '.png', 'abc.', 'abc', 'abc0', 'abc1', 'abc0.png', 'abc1.png' (num @ end)
-            '.png',
-            'abc',
-            'abc.',
-            'abc0',
-            'abc1',
-            'abc0.png',
-            'abc1.png',
-
-            // replacing # with _
-            str_replace('-', '#', $testimg), // test#image.png
-            str_replace('-', '##', $testimg), // test##image.png
-            str_replace(array('-', 'e'), '#', $testimg), // t#st#imag#.png
-            str_replace(array('-', 'e'), '##', $testimg), // t##st##imag##.png
-
-            // replacing \ or ' with nothing
-            str_replace('-', '\\', $testimg), // test\image.png
-            str_replace('-', '\\\\', $testimg), // test\\image.png
-            str_replace(array('-', 'e'), '\\', $testimg), // t\st\imag\.png
-            str_replace(array('-', 'e'), '\\\\', $testimg), // t\\st\\imag\\.png
-            str_replace('-', "'", $testimg), // test'image.png
-            str_replace('-', "'", $testimg), // test''image.png
-            str_replace(array('-', 'e'), "'", $testimg), // t'st'imag'.png
-            str_replace(array('-', 'e'), "''", $testimg), // t''st''imag''.png
-            str_replace('-', "\'", $testimg), // test\'image.png
-            str_replace('-', "\'\'", $testimg), // test\'\'image.png
-            str_replace(array('-', 'e'), "\'", $testimg), // t\'st\'imag\'.png
-            str_replace(array('-', 'e'), "\'\'", $testimg), // t\'\'st\'\'imag\'\'.png
-
-            'test' . str_replace('e', 'é', $testimg), // testtést-imagé.png
-
-            '12%af34567890~!@#$..%^&*()|_+qwerty  fgh`jkl zx<>?:"{}[]="\'/?.png', // kitchen sink
-            $testdir.'test-image-with-path.png',
-        );
-
-        // what we expect the replacements will do
-        $expected = array(
-                'null' . $testimg,
-
-                'png',
-                'abc',
-                'abc',
-                'abc0',
-                'abc1',
-                'abc0.png',
-                'abc1.png',
-
-                'testimage.png',
-                'testimage.png',
-                'tstimag.png',
-                'tstimag.png',
-
-                'testimage.png',
-                'testimage.png',
-                'tstimag.png',
-                'tstimag.png',
-                'testimage.png',
-                'testimage.png',
-                'tstimag.png',
-                'tstimag.png',
-                'testimage.png',
-                'testimage.png',
-                'tstimag.png',
-                'tstimag.png',
-
-                'testtést-imagé.png',
-
-                '12%af34567890@..%^_+qwerty-fghjkl-zx.png',
-                str_replace( array( '\\', '/', ':' ), '', $testdir ).'test-image-with-path.png',
-            );
-
-        foreach ($cases as $key => $case) {
-            // make sure expected file doesn't exist already
-            // happens when tests fail and the unlinking doesn't happen
-            if( $expected[$key] !== $testimg && file_exists($testdir . $expected[$key]) )
-                unlink($testdir . $expected[$key]);
-
-            // -- TEST 1: the replacement is as expected
-            $this->assertEquals( $expected[$key], wp_unique_filename($testdir, $case, NULL), $case );
-            // -- end TEST 1
-
-            // -- TEST 2: the renaming will produce a unique name
-            // create the expected file
-            copy($testdir . $testimg, $testdir . $expected[$key]);
-            // test that wp_unique_filename actually returns a unique filename
-            $this->assertFileNotExists( $testdir . wp_unique_filename($testdir, $case, NULL) );
-            // -- end TEST 2
-
-            // cleanup
-            if( $expected[$key] !== $testimg &&  file_exists($testdir . $expected[$key]) )
-                unlink($testdir . $expected[$key]);
-        }
+        
+        // sanity check
+        $this->assertEquals( 'abcdefg.png', wp_unique_filename( $testdir, 'abcdefg.png' ), 'Sanitiy check failed' );
+
+        // check number is appended for file already exists
+        $this->assertFileExists( $testdir . 'test-image.png', 'Test image does not exist' );
+        $this->assertEquals( 'test-image1.png', wp_unique_filename( $testdir, 'test-image.png' ), 'Number not appended correctly' );
+        $this->assertFileNotExists( $testdir . 'test-image1.png' );
+
+        // check special chars
+        $this->assertEquals( 'testtést-imagé.png', wp_unique_filename( $testdir, 'testtést-imagé.png' ), 'Filename with special chars failed' );
+        
+        // check special chars with potential conflicting name
+        $this->assertEquals( 'tést-imagé.png', wp_unique_filename( $testdir, 'tést-imagé.png' ), 'Filename with special chars failed' );
+        
+        // check with single quotes in name (somehow)
+        $this->assertEquals( "abcdefgh.png", wp_unique_filename( $testdir, "abcdefg'h.png" ), 'File with quote failed' );
+
+        // check with single quotes in name (somehow)
+        $this->assertEquals( "abcdefgh.png", wp_unique_filename( $testdir, 'abcdefg"h.png' ), 'File with quote failed' );
+
+        // test crazy name (useful for regression tests)
+        $this->assertEquals( '12%af34567890@..%^_+qwerty-fghjkl-zx.png', wp_unique_filename( $testdir, '12%af34567890#~!@#$..%^&*()|_+qwerty  fgh`jkl zx<>?:"{}[]="\'/?.png' ), 'Failed crazy file name' );
+        
+        // test slashes in names
+        $this->assertEquals( 'abcdefg.png', wp_unique_filename( $testdir, 'abcde\fg.png' ), 'Slash not removed' );
+        $this->assertEquals( 'abcdefg.png', wp_unique_filename( $testdir, 'abcde\\fg.png' ), 'Double slashed not removed' );
+        $this->assertEquals( 'abcdefg.png', wp_unique_filename( $testdir, 'abcde\\\fg.png' ), 'Tripple slashed not removed' );
     }