Changeset 12437

Timestamp:

12/17/2009 08:19:43 PM (15 years ago)

Author:

ryan

Message:

Give feedback when Upgrade Plugins is clicked but no plugins are selected. see #10973 for 2.9

File:

• branches/2.9/wp-admin/update-core.php (modified) (4 diffs)

branches/2.9/wp-admin/update-core.php

@@ -96 +96 @@
  */
 function core_upgrade_preamble() {
+    global $upgrade_error;
+
     $updates = get_core_updates();
 ?>
@@ -102 +104 @@
     <h2><?php _e('Upgrade WordPress'); ?></h2>
 <?php
+    if ( $upgrade_error ) {
+        echo '<div class="error"><p>';
+        _e('Please select one or more plugins to upgrade.');
+        echo '</p></div>';
+    }
+
     if ( !isset($updates[0]->response) || 'latest' == $updates[0]->response ) {
         echo '<h3>';
@@ -332 +340 @@
     if ( isset($_GET['plugins']) ) {
         $plugins = explode(',', $_GET['plugins']);
+    } elseif ( isset($_POST['checked']) ) {
+        $plugins = (array) $_POST['checked'];
     } else {
-        $plugins = (array) $_POST['checked'];
+        // Nothing to do.
+        return;
     }
     $url = 'update-core.php?action=do-plugin-upgrade&amp;plugins=' . urlencode(join(',', $plugins));
@@ -343 +354 @@
 
 $action = isset($_GET['action']) ? $_GET['action'] : 'upgrade-core';
+
+$upgrade_error = false;
+if ( 'do-plugin-upgrade' == $action && !isset($_GET['plugins']) && !isset($_POST['checked']) ) {
+    $upgrade_error = true;
+    $action = 'upgrade-core';
+}
 
 $title = __('Upgrade WordPress');