Changeset 12500

Timestamp:

12/23/2009 09:15:13 AM (16 years ago)

Author:

westi

Message:

Improve the revision comparison user interface to hilight that we compare "old on left" to "new on right". Includes some js to hide the radio buttons to stop you selecting reverse comparisions.
Fixes #11088 props filosofo.

Location:

trunk

Files:

• wp-admin/revision.php (modified) (1 diff)
• wp-includes/js/wp-list-revisions.dev.js (added)
• wp-includes/js/wp-list-revisions.js (added)
• wp-includes/post-template.php (modified) (3 diffs)
• wp-includes/script-loader.php (modified) (1 diff)

trunk/wp-admin/revision.php

@@ -9 +9 @@
 /** WordPress Administration Bootstrap */
 require_once('admin.php');
+
+wp_enqueue_script('list-revisions');
 
 wp_reset_vars(array('revision', 'left', 'right', 'diff', 'action'));

trunk/wp-includes/post-template.php

@@ -1300 +1300 @@
 
             $rows .= "<tr$class>\n";
-            $rows .= "\t<th style='white-space: nowrap' scope='row'><input type='radio' name='left' value='$revision->ID'$left_checked /><input type='radio' name='right' value='$revision->ID'$right_checked /></th>\n";
+            $rows .= "\t<th style='white-space: nowrap' scope='row'><input type='radio' name='left' value='$revision->ID'$left_checked />\n";
+            $rows .= "\t<th style='white-space: nowrap' scope='row'><input type='radio' name='right' value='$revision->ID'$right_checked /></th>\n";
             $rows .= "\t<td>$date</td>\n";
             $rows .= "\t<td>$name</td>\n";
@@ -1324 +1325 @@
 <br class="clear" />
 
-<table class="widefat post-revisions" cellspacing="0">
+<table class="widefat post-revisions" cellspacing="0" id="post-revisions">
+    <col />
     <col />
     <col style="width: 33%" />
@@ -1331 +1333 @@
 <thead>
 <tr>
-    <th scope="col"></th>
+    <th scope="col"><?php _e( 'Old' ); ?></th>
+    <th scope="col"><?php _e( 'New' ); ?></th>
     <th scope="col"><?php _e( 'Date Created' ); ?></th>
     <th scope="col"><?php _e( 'Author' ); ?></th>

trunk/wp-includes/script-loader.php

@@ -374 +374 @@
         $scripts->add_data( 'hoverIntent', 'group', 1 );
 
+        $scripts->add( 'list-revisions', "/wp-includes/js/wp-list-revisions$suffix.js", null, '20091223' );
+
         $scripts->add( 'media', "/wp-admin/js/media$suffix.js", array( 'jquery-ui-draggable' ), '20090415' );
         $scripts->add_data( 'media', 'group', 1 );