Changeset 12542

Timestamp:

12/25/2009 10:22:21 PM (15 years ago)

Author:

matt

Message:

Media editing: When you have many custom taxonomies this page can get rather long, or just normally, so adding a "save" button to the top as well, for easy access.

There was no place on this page that actually linked to the item being edited, so I hyperinked the thumbnail.

Location:

trunk/wp-admin

Files:

• includes/media.php (modified) (8 diffs)
• media.php (modified) (1 diff)

trunk/wp-admin/includes/media.php

@@ -1202 +1202 @@
     }
 
+    $attachment_url = get_permalink( $attachment_id );
+
     $item = "
     $type_html
@@ -1210 +1212 @@
         <thead class='media-item-info' id='media-head-$post->ID'>
         <tr>
-            <td class='A1B1' id='thumbnail-head-$post->ID' rowspan='5'><img class='thumbnail' src='$thumb_url' alt='' /></td>
+            <td class='A1B1' id='thumbnail-head-$post->ID' rowspan='5'>
+            <a href='$attachment_url' target='_blank'><img class='thumbnail' src='$thumb_url' alt='' /></a>
+            </td>
             <td><strong>" . __('File name:') . "</strong> $filename</td>
         </tr>
@@ -1442 +1446 @@
     <?php _e( 'Choose files to upload' ); ?>
     <div id="flash-browse-button"></div>
-    <span><input id="cancel-upload" disabled="disabled" onclick="cancelUpload()" type="button" value="<?php esc_attr_e('Cancel Upload'); ?>" class="button" /></span>
+    <span><input id="cancel-upload" disabled="disabled" onClick="cancelUpload()" type="button" value="<?php esc_attr_e('Cancel Upload'); ?>" class="button" /></span>
     </div>
 <?php do_action('post-flash-upload-ui'); ?>
@@ -1453 +1457 @@
     <p id="async-upload-wrap">
     <label class="screen-reader-text" for="async-upload"><?php _e('Upload'); ?></label>
-    <input type="file" name="async-upload" id="async-upload" /> <input type="submit" class="button" name="html-upload" value="<?php esc_attr_e('Upload'); ?>" /> <a href="#" onclick="try{top.tb_remove();}catch(e){}; return false;"><?php _e('Cancel'); ?></a>
+    <input type="file" name="async-upload" id="async-upload" /> <input type="submit" class="button" name="html-upload" value="<?php esc_attr_e('Upload'); ?>" /> <a href="#" onClick="try{top.tb_remove();}catch(e){}; return false;"><?php _e('Cancel'); ?></a>
     </p>
     <div class="clear"></div>
@@ -1773 +1777 @@
 
 <p class="ml-submit">
-<input type="button" class="button" style="display:none;" onmousedown="wpgallery.update();" name="insert-gallery" id="insert-gallery" value="<?php esc_attr_e( 'Insert gallery' ); ?>" />
-<input type="button" class="button" style="display:none;" onmousedown="wpgallery.update();" name="update-gallery" id="update-gallery" value="<?php esc_attr_e( 'Update gallery settings' ); ?>" />
+<input type="button" class="button" style="display:none;" onMouseDown="wpgallery.update();" name="insert-gallery" id="insert-gallery" value="<?php esc_attr_e( 'Insert gallery' ); ?>" />
+<input type="button" class="button" style="display:none;" onMouseDown="wpgallery.update();" name="update-gallery" id="update-gallery" value="<?php esc_attr_e( 'Update gallery settings' ); ?>" />
 </p>
 </div>
@@ -2001 +2005 @@
                 <input name="align" id="align-none" value="none" onclick="addExtImage.align=\'align\'+this.value" type="radio"' . ($default_align == 'none' ? ' checked="checked"' : '').' />
                 <label for="align-none" class="align image-align-none-label">' . __('None') . '</label>
-                <input name="align" id="align-left" value="left" onclick="addExtImage.align=\'align\'+this.value" type="radio"' . ($default_align == 'left' ? ' checked="checked"' : '').' />
+                <input name="align" id="align-left" value="left" onClick="addExtImage.align=\'align\'+this.value" type="radio"' . ($default_align == 'left' ? ' checked="checked"' : '').' />
                 <label for="align-left" class="align image-align-left-label">' . __('Left') . '</label>
-                <input name="align" id="align-center" value="center" onclick="addExtImage.align=\'align\'+this.value" type="radio"' . ($default_align == 'center' ? ' checked="checked"' : '').' />
+                <input name="align" id="align-center" value="center" onClick="addExtImage.align=\'align\'+this.value" type="radio"' . ($default_align == 'center' ? ' checked="checked"' : '').' />
                 <label for="align-center" class="align image-align-center-label">' . __('Center') . '</label>
-                <input name="align" id="align-right" value="right" onclick="addExtImage.align=\'align\'+this.value" type="radio"' . ($default_align == 'right' ? ' checked="checked"' : '').' />
+                <input name="align" id="align-right" value="right" onClick="addExtImage.align=\'align\'+this.value" type="radio"' . ($default_align == 'right' ? ' checked="checked"' : '').' />
                 <label for="align-right" class="align image-align-right-label">' . __('Right') . '</label>
             </td>
@@ -2016 +2020 @@
             <td class="field"><input id="url" name="url" value="" type="text" /><br />
 
-            <button type="button" class="button" value="" onclick="document.forms[0].url.value=null">' . __('None') . '</button>
-            <button type="button" class="button" value="" onclick="document.forms[0].url.value=document.forms[0].src.value">' . __('Link to image') . '</button>
+            <button type="button" class="button" value="" onClick="document.forms[0].url.value=null">' . __('None') . '</button>
+            <button type="button" class="button" value="" onClick="document.forms[0].url.value=document.forms[0].src.value">' . __('Link to image') . '</button>
             <p class="help">' . __('Enter a link URL or click above for presets.') . '</p></td>
         </tr>
@@ -2024 +2028 @@
             <td></td>
             <td>
-                <input type="button" class="button" id="go_button" style="color:#bbb;" onclick="addExtImage.insert()" value="' . esc_attr__('Insert into Post') . '" />
+                <input type="button" class="button" id="go_button" style="color:#bbb;" onClick="addExtImage.insert()" value="' . esc_attr__('Insert into Post') . '" />
             </td>
         </tr>

trunk/wp-admin/media.php

@@ -91 +91 @@
 
 <form method="post" action="<?php echo esc_url( remove_query_arg( 'message' ) ); ?>" class="media-upload-form" id="media-single-form">
+<p class="submit">
+<input type="submit" class="button-primary" name="save" value="<?php esc_attr_e('Update Media'); ?>" />
+</p>
+
 <div class="media-single">
 <div id='media-item-<?php echo $att_id; ?>' class='media-item'>