Changeset 12655

Timestamp:

01/08/2010 05:23:22 AM (14 years ago)

Author:

azaozz

Message:

Optimize scan for lost attachments, props johnjosephbachir, fixes #10911

File:

• trunk/wp-admin/upload.php (modified) (1 diff)

trunk/wp-admin/upload.php

@@ -21 +21 @@
         wp_die( __('You are not allowed to scan for lost attachments.') );
 
-    $all_posts = $wpdb->get_col("SELECT ID FROM $wpdb->posts WHERE post_type = 'post' OR post_type = 'page'");
-    $all_att = $wpdb->get_results("SELECT ID, post_parent FROM $wpdb->posts WHERE post_type = 'attachment'");
-
-    $lost = array();
-    foreach ( (array) $all_att as $att ) {
-        if ( $att->post_parent > 0 && ! in_array($att->post_parent, $all_posts) )
-            $lost[] = $att->ID;
-    }
+    $all_posts = implode(',', $wpdb->get_col("SELECT ID FROM $wpdb->posts WHERE post_type IN ('post', 'page')"));
+    $lost = $wpdb->get_col("SELECT ID FROM $wpdb->posts WHERE post_type = 'attachment' AND post_parent > '0' and post_parent NOT IN ($all_posts)");
+
     $_GET['detached'] = 1;