Changeset 12848 for trunk/wp-admin/includes/plugin.php

Timestamp:

01/26/2010 06:39:12 PM (17 years ago)

Author:

ryan

Message:

Remove fix_actve_plugins(). Props hakre. fixes #11750

File:

• trunk/wp-admin/includes/plugin.php (modified) (4 diffs)

trunk/wp-admin/includes/plugin.php

@@ -259 +259 @@
  * @return bool True, if in the active plugins list. False, not in the list.
  */
-function is_plugin_active($plugin) {
-        return in_array( $plugin, apply_filters( 'active_plugins', get_option( 'active_plugins' ) ) );
+function is_plugin_active( $plugin ) {
+        return in_array( $plugin, apply_filters( 'active_plugins', get_option( 'active_plugins', array() ) ) );
 }
 
@@ -287 +287 @@
  * @return WP_Error|null WP_Error on invalid file or null on success.
  */
-function activate_plugin($plugin, $redirect = '') {
-        $current = get_option('active_plugins');
-        $plugin = plugin_basename(trim($plugin));
+function activate_plugin( $plugin, $redirect = '' ) {
+        $current = get_option( 'active_plugins', array() );
+        $plugin  = plugin_basename( trim( $plugin ) );
 
         $valid = validate_plugin($plugin);
@@ -323 +323 @@
  * @param bool $silent Optional, default is false. Prevent calling deactivate hook.
  */
-function deactivate_plugins($plugins, $silent= false) {
-        $current = get_option('active_plugins');
-
-        if ( !is_array($plugins) )
-                $plugins = array($plugins);
-
-        foreach ( $plugins as $plugin ) {
+function deactivate_plugins( $plugins, $silent = false ) {
+        $current = get_option( 'active_plugins', array() );
+
+        foreach ( (array) $plugins as $plugin ) {
                 $plugin = plugin_basename($plugin);
                 if ( ! is_plugin_active($plugin) )
@@ -476 +473 @@
 }
 
+/**
+ * validate active plugins
+ * 
+ * validate all active plugins, deactivates invalid and 
+ * returns an array of deactived ones.
+ * 
+ * @since unknown
+ * @return array invalid plugins, plugin as key, error as value
+ */
 function validate_active_plugins() {
-        $check_plugins = apply_filters( 'active_plugins', get_option('active_plugins') );
-
-        // Sanity check.  If the active plugin list is not an array, make it an
-        // empty array.
-        if ( !is_array($check_plugins) ) {
+        $plugins = apply_filters( 'active_plugins', get_option( 'active_plugins', array() ) );
+
+        // validate vartype: array
+        if ( !is_array( $plugins ) ) {
                 update_option('active_plugins', array());
                 return;
         }
 
-        //Invalid is any plugin that is deactivated due to error.
         $invalid = array();
 
-        // If a plugin file does not exist, remove it from the list of active
-        // plugins.
-        foreach ( $check_plugins as $check_plugin ) {
-                $result = validate_plugin($check_plugin);
+        // invalid plugins get deactivated
+        foreach ( $plugins as $plugin ) {
+                $result = validate_plugin( $plugin );
                 if ( is_wp_error( $result ) ) {
-                        $invalid[$check_plugin] = $result;
-                        deactivate_plugins( $check_plugin, true);
+                        $invalid[$plugin] = $result;
+                        deactivate_plugins( $plugin, true );
                 }
         }