Changeset 13 in tests

Timestamp:

09/20/2007 11:46:13 AM (19 years ago)

Author:

tellyworth

Message:

fix test_vb_insert_future_edit_bug

File:

• wp-testcase/test_includes_post.php (modified) (2 diffs)

wp-testcase/test_includes_post.php

@@ -74 +74 @@
                 $this->assertEquals(array($id), $cron_args['args']);
         }
+        
+        // helper function: return the timestamp(s) of cron jobs for the specified hook and post
+        function _next_schedule_for_post($hook, $id) {
+                return wp_next_scheduled('publish_future_post', array(0=>strval($id)));
+        }
 
         function test_vb_insert_future_edit_bug() {
-                // there was a bug that happens when you publish a future post, then change
-                // the timestamp - the original cron schedule is left intact so it's
-                // published at the wrong time.
+                // future post bug: posts get published at the wrong time if you edit the timestamp
+                // http://trac.wordpress.org/ticket/4710
 
                 $future_date_1 = strtotime('+1 day');
@@ -93 +97 @@
                 // insert a post and make sure the ID is ok
                 $id = $this->post_ids[] = wp_insert_post($post);
-                #dmp(_get_cron_array());
-                $this->assertTrue(is_numeric($id));
-                $this->assertTrue($id > 0);
 
-                $cron = _get_cron_array();
-                dmp($future_date_1, $cron);
+                // fetch the post and make sure has the correct date and status
+                $out = wp_get_single_post($id);
+                $this->assertEquals('future', $out->post_status);
+                $this->assertEquals($post['post_date'], $out->post_date);
+
+                // check that there's a publish_future_post job scheduled at the right time
+                $this->assertEquals($future_date_1, $this->_next_schedule_for_post('publish_future_post', $id));
 
                 // now save it again with a date further in the future
 
-                // fetch the post and make sure it matches
+                $post['ID'] = $id;
+                $post['post_date'] = strftime("%Y-%m-%d %H:%M:%S", $future_date_2);
+                $post['post_date_gmt'] = NULL;
+                wp_update_post($post);
+
+                // fetch the post again and make sure it has the new post_date
                 $out = wp_get_single_post($id);
-
-                $this->assertEquals($post['post_content'], $out->post_content);
-                $this->assertEquals($post['post_title'], $out->post_title);
                 $this->assertEquals('future', $out->post_status);
-                $this->assertEquals($post['post_author'], $out->post_author);
                 $this->assertEquals($post['post_date'], $out->post_date);
 
-                // now change the date
-                $post['ID'] = $id;
-                $post['post_date'] = strftime("%Y-%m-%d %H:%M:%S", $future_date_1);
-                wp_update_post($post);
-
-                $this->assertEquals($post['post_content'], $out->post_content);
-                $this->assertEquals($post['post_title'], $out->post_title);
-                $this->assertEquals('future', $out->post_status);
-                $this->assertEquals($post['post_author'], $out->post_author);
-                $this->assertEquals($post['post_date'], $out->post_date);
-
-                $cron = _get_cron_array();
-                dmp($future_date_2, $cron);
-
-                $this->assertTrue(is_array($cron[$future_date_2]['publish_future_post']));
-                $cron_args = array_pop($cron[$future_date_2]['publish_future_post']);
-                $this->assertEquals('future', $cron_args['schedule']);
-                $this->assertEquals(array($id), $cron_args['args']);
+                // and the correct date on the cron job
+                $this->assertEquals($future_date_2, $this->_next_schedule_for_post('publish_future_post', $id));
         }