Changeset 13053

Timestamp:

02/11/2010 04:17:12 PM (11 years ago)

Author:

ryan

Message:

Test explicitly for false from insert()/update(). Fixes early return that preventing link categories from being saved. fixes #12196

File:

• trunk/wp-admin/includes/bookmark.php (modified) (2 diffs)

trunk/wp-admin/includes/bookmark.php

@@ -187 +187 @@
 
     if ( $update ) {
-        if ( ! $wpdb->update( $wpdb->links, compact('link_url', 'link_name', 'link_image', 'link_target', 'link_description', 'link_visible', 'link_rating', 'link_rel', 'link_notes', 'link_rss'), compact('link_id') ) ) {
+        if ( false === $wpdb->update( $wpdb->links, compact('link_url', 'link_name', 'link_image', 'link_target', 'link_description', 'link_visible', 'link_rating', 'link_rel', 'link_notes', 'link_rss'), compact('link_id') ) ) {
             if ( $wp_error )
                 return new WP_Error( 'db_update_error', __( 'Could not update link in the database' ), $wpdb->last_error );
@@ -194 +194 @@
         }
     } else {
-        if ( ! $wpdb->insert( $wpdb->links, compact('link_url', 'link_name', 'link_image', 'link_target', 'link_description', 'link_visible', 'link_owner', 'link_rating', 'link_rel', 'link_notes', 'link_rss') ) ) {
+        if ( false === $wpdb->insert( $wpdb->links, compact('link_url', 'link_name', 'link_image', 'link_target', 'link_description', 'link_visible', 'link_owner', 'link_rating', 'link_rel', 'link_notes', 'link_rss') ) ) {
             if ( $wp_error )
                 return new WP_Error( 'db_insert_error', __( 'Could not insert link into the database' ), $wpdb->last_error );