Changeset 13095

Timestamp:

02/13/2010 07:09:04 AM (15 years ago)

Author:

dd32

Message:

Correctly save checkbox-style MS options and display "No" checked value correctly. See #11644

Location:

trunk/wp-admin

Files:

• ms-edit.php (modified) (1 diff)
• ms-options.php (modified) (2 diffs)

trunk/wp-admin/ms-edit.php

@@ -103 +103 @@
         update_site_option( "dashboard_blog", $dashboard_blog_id );
         $options = array( 'registrationnotification', 'registration', 'add_new_users', 'menu_items', 'mu_media_buttons', 'upload_space_check_disabled', 'blog_upload_space', 'upload_filetypes', 'site_name', 'first_post', 'first_page', 'first_comment', 'first_comment_url', 'first_comment_author', 'welcome_email', 'welcome_user_email', 'fileupload_maxk', 'admin_notice_feed' );
+        $checked_options = array('mu_media_buttons', 'menu_items');
+        foreach ( $checked_options as $option_name ) {
+            if ( ! isset($_POST[ $option_name ]) )
+                $_POST[ $option_name ] = array();
+        }
         foreach ( $options as $option_name ) {
             if ( ! isset($_POST[ $option_name ]) )

trunk/wp-admin/ms-options.php

@@ -81 +81 @@
                     <a name='addnewusers'></a>
                     <input name="add_new_users" type="radio" id="add_new_users1" value='1' <?php checked( get_site_option('add_new_users') ) ?> /> <?php _e('Yes'); ?><br />
-                    <input name="add_new_users" type="radio" id="add_new_users2" value='0' <?php checked( get_site_option('add_new_users'), false) ?> /> <?php _e('No'); ?><br />
+                    <input name="add_new_users" type="radio" id="add_new_users2" value='0' <?php checked( get_site_option('add_new_users'), 0) ?> /> <?php _e('No'); ?><br />
                     <?php _e('Allow blog administrators to add new users to their blog via the Users->Add New page.') ?>
                 </td>
@@ -211 +211 @@
                 <th scope="row"><?php _e('Blog upload space check') ?></th>
                 <td>
-                <label><input type='radio' id="upload_space_check_disabled" name="upload_space_check_disabled" value='0' <?php checked( get_site_option( 'upload_space_check_disabled' ), false ) ?>/> <?php _e( 'Enabled' ); ?></label><br />
+                <label><input type='radio' id="upload_space_check_disabled" name="upload_space_check_disabled" value='0' <?php checked( get_site_option( 'upload_space_check_disabled' ), 0 ) ?>/> <?php _e( 'Enabled' ); ?></label><br />
                 <label><input type='radio' id="upload_space_check_disabled" name="upload_space_check_disabled" value='1' <?php checked( get_site_option( 'upload_space_check_disabled' ) ) ?>/> <?php _e( 'Disabled' ); ?></label><br />
                 <?php _e( 'By default there is a limit on the total size of files uploaded but it can be disabled here.' ); ?></td>