Changeset 13347

Timestamp:

02/23/2010 10:42:54 PM (16 years ago)

Author:

nacin

Message:

Validate $object_id in *_metadata() functions. Props scribu fixes #11841

File:

• trunk/wp-includes/meta.php (modified) (4 diffs)

trunk/wp-includes/meta.php

@@ -33 +33 @@
         return false;
 
+    if ( !$object_id = absint($object_id) )
+        return false;
+
     if ( ! $table = _get_meta_table($meta_type) )
         return false;
@@ -84 +87 @@
 function update_metadata($meta_type, $object_id, $meta_key, $meta_value, $prev_value = '') {
     if ( !$meta_type || !$meta_key )
+        return false;
+
+    if ( !$object_id = absint($object_id) )
         return false;
 
@@ -139 +145 @@
  */
 function delete_metadata($meta_type, $object_id, $meta_key, $meta_value = '', $delete_all = false) {
-    if ( !$meta_type || !$meta_key || (!$delete_all && ! (int)$object_id) )
+    if ( !$meta_type || !$meta_key )
+        return false;
+
+    if ( !$object_id = absint($object_id) && !$delete_all )
         return false;
 
@@ -196 +205 @@
         return false;
 
+    if ( !$object_id = absint($object_id) )
+        return false;
+
     $meta_cache = wp_cache_get($object_id, $meta_type . '_meta');