Changeset 13353

Timestamp:

02/24/2010 12:18:18 AM (11 years ago)

Author:

nacin

Message:

Don't use private wpdb vars. See #11644

Location:

trunk

Files:

• wp-includes/comment.php (modified) (1 diff)
• xmlrpc.php (modified) (1 diff)

trunk/wp-includes/comment.php

@@ -1383 +1383 @@
 
     $data = compact('comment_content', 'comment_author', 'comment_author_email', 'comment_approved', 'comment_karma', 'comment_author_url', 'comment_date', 'comment_date_gmt');
-    $wpdb->update($wpdb->comments, $data, compact('comment_ID'));
-
-    $rval = $wpdb->rows_affected;
+    $rval = $wpdb->update( $wpdb->comments, $data, compact( 'comment_ID' ) );
 
     clean_comment_cache($comment_ID);

trunk/xmlrpc.php

@@ -3204 +3204 @@
 
         // Let's check that the remote site didn't already pingback this entry
-        $wpdb->get_results( $wpdb->prepare("SELECT * FROM $wpdb->comments WHERE comment_post_ID = %d AND comment_author_url = %s", $post_ID, $pagelinkedfrom) );
-
-        if ( $wpdb->num_rows ) // We already have a Pingback from this URL
-            return new IXR_Error(48, __('The pingback has already been registered.'));
+        if ( $wpdb->get_results( $wpdb->prepare("SELECT * FROM $wpdb->comments WHERE comment_post_ID = %d AND comment_author_url = %s", $post_ID, $pagelinkedfrom) ) )
+            return new IXR_Error( 48, __( 'The pingback has already been registered.' ) );
 
         // very stupid, but gives time to the 'from' server to publish !