Changeset 13553 for trunk/wp-includes/category-template.php

Timestamp:

03/02/2010 06:36:49 PM (17 years ago)

Author:

nacin

Message:

Add id argument to wp_dropdown_users() and wp_dropdown_categories(). props johnbillion. Ensure we're escaping name and id in wp_dropdown_users(). fixes #12132

File:

• trunk/wp-includes/category-template.php (modified) (3 diffs)

trunk/wp-includes/category-template.php

@@ -315 +315 @@
  *     'depth' (int) - The max depth.
  *     'tab_index' (int) - Tab index for select element.
- *     'name' (string) - The name attribute value for selected element.
- *     'class' (string) - The class attribute value for selected element.
+ *     'name' (string) - The name attribute value for select element.
+ *     'id' (string) - The ID attribute value for select element. Defaults to name if omitted.
+ *     'class' (string) - The class attribute value for select element.
  *     'selected' (int) - Which category ID is selected.
  *
@@ -337 +338 @@
                 'exclude' => '', 'echo' => 1,
                 'selected' => 0, 'hierarchical' => 0,
-                'name' => 'cat', 'class' => 'postform',
-                'depth' => 0, 'tab_index' => 0,
-                'taxonomy' => 'category', 'hide_if_empty' => false
+                'name' => 'cat', 'id' => '',
+                'class' => 'postform', 'depth' => 0,
+                'tab_index' => 0, 'taxonomy' => 'category',
+                'hide_if_empty' => false
         );
 
@@ -358 +360 @@
 
         $categories = get_terms( $taxonomy, $r );
-        $name = esc_attr($name);
-        $class = esc_attr($class);
+        $name = esc_attr( $name );
+        $class = esc_attr( $class );
+        $id = $id ? esc_attr( $id ) : $name;
 
         if ( ! $r['hide_if_empty'] || ! empty($categories) )
-                $output = "<select name='$name' id='$name' class='$class' $tab_index_attribute>\n";
+                $output = "<select name='$name' id='$id' class='$class' $tab_index_attribute>\n";
         else
                 $output = '';