Changeset 13617

Timestamp:

03/08/2010 02:30:17 PM (15 years ago)

Author:

nacin

Message:

Fix warning in users.php. Fixes #12555

Location:

trunk

Files:

• wp-admin/users.php (modified) (1 diff)
• wp-includes/user.php (modified) (1 diff)

trunk/wp-admin/users.php

@@ -371 +371 @@
 
     $style = ( ' class="alternate"' == $style ) ? '' : ' class="alternate"';
-    echo "\n\t", user_row($user_object, $style, $role, $post_counts[(string)$userid]);
+    echo "\n\t", user_row($user_object, $style, $role, isset( $post_counts[ $userid ] ) ? $post_counts[ $userid ] : 0 );
 }
 ?>

trunk/wp-includes/user.php

@@ -168 +168 @@
 function count_many_users_posts($users) {
     global $wpdb;
-    
-    if (0 == count($users))
-        return array();
-        
-    $userlist = implode(',', $users);
-    $where = get_posts_by_author_sql('post');
+
+    $count = array();
+    if ( ! count( $users ) )
+        return $count;
+
+    $userlist = implode( ',', $users );
+    $where = get_posts_by_author_sql( 'post' );
 
     $result = $wpdb->get_results( "SELECT post_author, COUNT(*) FROM $wpdb->posts $where AND post_author IN ($userlist) GROUP BY post_author", ARRAY_N );
 
-    $count = array();
-    foreach($result as $row) {
-        $count[$row[0]] = $row[1];
-    }
-
-    foreach($users as $id) {
-        $id = (string) $id;
-        if (!isset($count[$id]))
-            $count[$id] = 0;
+    if ( ! $result )
+        return $count;
+
+    foreach ( $result as $row ) {
+        $count[ $row[0] ] = $row[1];
+    }
+
+    foreach ( $users as $id ) {
+        if ( ! isset( $count[ $id ] ) )
+            $count[ $id ] = 0;
     }