Changeset 14426 for trunk/wp-includes/post.php

Timestamp:

05/03/2010 11:35:22 PM (16 years ago)

Author:

dd32

Message:

Handle $_POST containing an empty term array, Fixes saving of deselecting all hierarchical terms. Fixes #10122

File:

• trunk/wp-includes/post.php (modified) (4 diffs)

trunk/wp-includes/post.php

@@ -2071 +2071 @@
         if ( empty($post_type) )
                 $post_type = 'post';
+
+        if ( !empty($post_category) )
+                $post_category = array_filter($post_category); // Filter out empty terms
 
         // Make sure we set a valid category.
@@ -2226 +2229 @@
         wp_set_post_categories( $post_ID, $post_category );
         // old-style tags_input
-        if ( isset( $tags_input ) )
+        if ( isset( $tags_input ) ) {
+                $tags_input = array_filter($tags_input);
                 wp_set_post_tags( $post_ID, $tags_input );
-        // new-style support for all tag-like taxonomies
+        }
+        // new-style support for all custom taxonomies
         if ( !empty($tax_input) ) {
                 foreach ( $tax_input as $taxonomy => $tags ) {
                         $taxonomy_obj = get_taxonomy($taxonomy);
+                        if ( is_array($tags) ) // array = hierarchical, string = non-hierarchical.
+                                $tags = array_filter($tags);
                         if ( current_user_can($taxonomy_obj->assign_cap) )
                                 wp_set_post_terms( $post_ID, $tags, $taxonomy );
@@ -2785 +2792 @@
         $page_paths = explode('/', $page_paths);
         $full_path = '';
-        foreach( (array) $page_paths as $pathdir)
-                $full_path .= ($pathdir!=''?'/':'') . sanitize_title($pathdir);
+        foreach ( (array) $page_paths as $pathdir )
+                $full_path .= ( $pathdir != '' ? '/' : '' ) . sanitize_title($pathdir);
 
         $pages = $wpdb->get_results( $wpdb->prepare( "SELECT ID, post_name, post_parent FROM $wpdb->posts WHERE post_name = %s AND (post_type = %s OR post_type = 'attachment')", $leaf_path, $post_type ));
@@ -3669 +3676 @@
  */
 function wp_check_for_changed_slugs($post_id) {
-        if ( !isset($_POST['wp-old-slug']) || !strlen($_POST['wp-old-slug']) )
+        if ( empty($_POST['wp-old-slug']) )
                 return $post_id;