Make WordPress Core

Changeset 14563


Ignore:
Timestamp:
05/11/2010 04:50:25 PM (16 years ago)
Author:
ryan
Message:

Don't order term count queries.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/wp-includes/taxonomy.php

    r14480 r14563  
    820820        else if ( 'term_group' == $_orderby )
    821821                $orderby = 't.term_group';
     822        else if ( 'none' == $_orderby )
     823                $orderby = '';
    822824        elseif ( empty($_orderby) || 'id' == $_orderby )
    823825                $orderby = 't.term_id';
    824826
    825827        $orderby = apply_filters( 'get_terms_orderby', $orderby, $args );
     828
     829        if ( !empty($orderby) )
     830                $orderby = "ORDER BY $orderby";
     831        else
     832                $order = '';
    826833
    827834        $where = '';
     
    917924                        break;
    918925                case 'count':
     926                        $orderby = '';
     927                        $order = '';
    919928                        $selects = array('COUNT(*)');
    920929        }
    921930    $select_this = implode(', ', apply_filters( 'get_terms_fields', $selects, $args ));
    922931
    923         $query = "SELECT $select_this FROM $wpdb->terms AS t INNER JOIN $wpdb->term_taxonomy AS tt ON t.term_id = tt.term_id WHERE tt.taxonomy IN ($in_taxonomies) $where ORDER BY $orderby $order $limit";
     932        $query = "SELECT $select_this FROM $wpdb->terms AS t INNER JOIN $wpdb->term_taxonomy AS tt ON t.term_id = tt.term_id WHERE tt.taxonomy IN ($in_taxonomies) $where $orderby $order $limit";
    924933
    925934        if ( 'count' == $fields ) {
Note: See TracChangeset for help on using the changeset viewer.