Changeset 14654 for trunk/wp-admin/menu.php

Timestamp:

05/15/2010 05:38:40 AM (15 years ago)

Author:

nacin

Message:

Make sure custom post types have unique IDs in the admin menu. props validBen, fixes #12445.

File:

• trunk/wp-admin/menu.php (modified) (2 diffs)

trunk/wp-admin/menu.php

@@ -117 +117 @@
     $ptype_obj = get_post_type_object( $ptype );
     $ptype_menu_position = is_int( $ptype_obj->menu_position ) ? $ptype_obj->menu_position : $_wp_last_object_menu++; // If we're to use $_wp_last_object_menu, increment it first.
+    $ptype_for_id = sanitize_html_class( $ptype );
     if ( is_string( $ptype_obj->menu_icon ) ) {
         $menu_icon   = esc_url( $ptype_obj->menu_icon );
-        $ptype_class = sanitize_html_class( $ptype );
+        $ptype_class = $ptype_for_id;
     } else {
         $menu_icon   = 'div';
@@ -130 +131 @@
         $ptype_menu_position++;
 
-    $menu[$ptype_menu_position] = array( esc_attr( $ptype_obj->labels->name ), $ptype_obj->cap->edit_posts, "edit.php?post_type=$ptype", '', 'menu-top menu-icon-' . $ptype_class, 'menu-' . $ptype_class, $menu_icon );
+    $menu[$ptype_menu_position] = array( esc_attr( $ptype_obj->labels->name ), $ptype_obj->cap->edit_posts, "edit.php?post_type=$ptype", '', 'menu-top menu-icon-' . $ptype_class, 'menu-posts-' . $ptype_for_id, $menu_icon );
     $submenu["edit.php?post_type=$ptype"][5]  = array( $ptype_obj->labels->edit, $ptype_obj->cap->edit_posts,  "edit.php?post_type=$ptype");
     $submenu["edit.php?post_type=$ptype"][10]  = array( $ptype_obj->labels->add_new, $ptype_obj->cap->edit_posts, "post-new.php?post_type=$ptype" );