Changeset 14814

Timestamp:

05/23/2010 07:49:21 AM (13 years ago)

Author:

dd32

Message:

Introduce a 'post_updated' action, Fires when a post is updated, Post ID, Current and Previous post objects are passed. Updatewp_check_for_changed_slugs() to use new hook. See #12473

Location:

trunk

Files:

• wp-admin/includes/template.php (modified) (1 diff)
• wp-includes/default-filters.php (modified) (1 diff)
• wp-includes/post.php (modified) (4 diffs)

trunk/wp-admin/includes/template.php

@@ -2763 +2763 @@
 
 /**
- * {@internal Missing Short Description}}
- *
- * @since unknown
- */
-function wp_remember_old_slug() {
-    global $post;
-    $name = esc_attr($post->post_name); // just in case
-    if ( strlen($name) )
-        echo '<input type="hidden" id="wp-old-slug" name="wp-old-slug" value="' . $name . '" />';
-}
-
-/**
  * Add a meta box to an edit form.
  *

trunk/wp-includes/default-filters.php

@@ -236 +236 @@
 
 // Redirect Old Slugs
-add_action( 'template_redirect',  'wp_old_slug_redirect'       );
-add_action( 'edit_post',          'wp_check_for_changed_slugs' );
-add_action( 'edit_form_advanced', 'wp_remember_old_slug'       );
-add_action( 'init',               '_show_post_preview'         );
+add_action( 'template_redirect', 'wp_old_slug_redirect'              );
+add_action( 'post_updated',      'wp_check_for_changed_slugs', 12, 3 );
+
+// Nonce check for Post Previews
+add_action( 'init', '_show_post_preview' );
 
 // Timezone

trunk/wp-includes/post.php

@@ -1656 +1656 @@
  *
  * @param string|array $mime_types List of mime types or comma separated string of mime types.
- * @param string $table_alias Optional. Specify a table alias, if needed. 
+ * @param string $table_alias Optional. Specify a table alias, if needed.
  * @return string The SQL AND clause for mime searching.
  */
@@ -2200 +2200 @@
         $post_ID = (int) $ID;
         $guid = get_post_field( 'guid', $post_ID );
+        $post_before = get_post($post_ID);
     }
 
@@ -2375 +2376 @@
     wp_transition_post_status($data['post_status'], $previous_status, $post);
 
-    if ( $update )
+    if ( $update ) {
         do_action('edit_post', $post_ID, $post);
+        $post_after = get_post($post_ID);
+        do_action( 'post_updated', $post_ID, $post_after, $post_before);
+    }
 
     do_action('save_post', $post_ID, $post);
@@ -3779 +3783 @@
  * @return int Same as $post_id
  */
-function wp_check_for_changed_slugs($post_id) {
-    if ( empty($_POST['wp-old-slug']) )
-        return $post_id;
-
-    $post = &get_post($post_id);
+function wp_check_for_changed_slugs($post_id, $post, $post_before) {
+    // dont bother if it hasnt changed
+    if ( $post->post_name == $post_before->post_name )
+        return;
 
     // we're only concerned with published posts
     if ( $post->post_status != 'publish' || $post->post_type != 'post' )
-        return $post_id;
-
-    // only bother if the slug has changed
-    if ( $post->post_name == $_POST['wp-old-slug'] )
-        return $post_id;
+        return;
 
     $old_slugs = (array) get_post_meta($post_id, '_wp_old_slug');
 
     // if we haven't added this old slug before, add it now
-    if ( !count($old_slugs) || !in_array($_POST['wp-old-slug'], $old_slugs) )
-        add_post_meta($post_id, '_wp_old_slug', $_POST['wp-old-slug']);
+    if ( !in_array($post_before->post_name, $old_slugs) )
+        add_post_meta($post_id, '_wp_old_slug', $post_before->post_name);
 
     // if the new slug was used previously, delete it from the list
     if ( in_array($post->post_name, $old_slugs) )
         delete_post_meta($post_id, '_wp_old_slug', $post->post_name);
-
-    return $post_id;
 }