Changeset 14930

Timestamp:

05/26/2010 03:57:55 AM (14 years ago)

Author:

nacin

Message:

Hide Flash uploader and theme/plugin editor documentation feature, if no JS. Also some validation fixes in the theme editor. props ocean90. see #13383.

Location:

trunk/wp-admin

Files:

• includes/media.php (modified) (2 diffs)
• media-upload.php (modified) (1 diff)
• plugin-editor.php (modified) (1 diff)
• theme-editor.php (modified) (1 diff)

trunk/wp-admin/includes/media.php

@@ -1490 +1490 @@
 </script>
 
-<div id="flash-upload-ui">
+<div id="flash-upload-ui" class="hide-if-no-js">
 <?php do_action('pre-flash-upload-ui'); ?>
 
@@ -2232 +2232 @@
  */
 function media_upload_html_bypass($flash = true) {
-    echo '<p class="upload-html-bypass">';
+    echo '<p class="upload-html-bypass hide-if-no-js">';
     _e('You are using the Browser uploader.');
     if ( $flash ) {

trunk/wp-admin/media-upload.php

@@ -89 +89 @@
     <input type="hidden" name="post_id" id="post_id" value="0" />
     <?php wp_nonce_field('media-form'); ?>
-    <div id="media-items"> </div>
+    <div id="media-items" class="hide-if-no-js"> </div>
     <p>
-    <input type="submit" class="button savebutton" name="save" value="<?php esc_attr_e( 'Save all changes' ); ?>" />
+    <input type="submit" class="button savebutton hide-if-no-js" name="save" value="<?php esc_attr_e( 'Save all changes' ); ?>" />
     </p>
     </form>

trunk/wp-admin/plugin-editor.php

@@ -212 +212 @@
         </div>
         <?php if ( !empty( $docs_select ) ) : ?>
-        <div id="documentation"><label for="docs-list"><?php _e('Documentation:') ?></label> <?php echo $docs_select ?> <input type="button" class="button" value="<?php esc_attr_e( 'Lookup' ) ?> " onclick="if ( '' != jQuery('#docs-list').val() ) { window.open( 'http://api.wordpress.org/core/handbook/1.0/?function=' + escape( jQuery( '#docs-list' ).val() ) + '&amp;locale=<?php echo urlencode( get_locale() ) ?>&amp;version=<?php echo urlencode( $wp_version ) ?>&amp;redirect=true'); }" /></div>
+        <div id="documentation" class="hide-if-no-js"><label for="docs-list"><?php _e('Documentation:') ?></label> <?php echo $docs_select ?> <input type="button" class="button" value="<?php esc_attr_e( 'Lookup' ) ?> " onclick="if ( '' != jQuery('#docs-list').val() ) { window.open( 'http://api.wordpress.org/core/handbook/1.0/?function=' + escape( jQuery( '#docs-list' ).val() ) + '&amp;locale=<?php echo urlencode( get_locale() ) ?>&amp;version=<?php echo urlencode( $wp_version ) ?>&amp;redirect=true'); }" /></div>
         <?php endif; ?>
 <?php if ( is_writeable($real_file) ) : ?>

trunk/wp-admin/theme-editor.php

@@ -202 +202 @@
          </div>
     <?php if ( isset($functions ) && count($functions) ) { ?>
-        <div id="documentation">
+        <div id="documentation" class="hide-if-no-js">
         <label for="docs-list"><?php _e('Documentation:') ?></label>
         <?php echo $docs_select; ?>
-        <input type="button" class="button" value=" <?php esc_attr_e( 'Lookup' ); ?> " onclick="if ( '' != jQuery('#docs-list').val() ) { window.open( 'http://api.wordpress.org/core/handbook/1.0/?function=' + escape( jQuery( '#docs-list' ).val() ) + '&locale=<?php echo urlencode( get_locale() ) ?>&version=<?php echo urlencode( $wp_version ) ?>&redirect=true'); }" />
+        <input type="button" class="button" value=" <?php esc_attr_e( 'Lookup' ); ?> " onclick="if ( '' != jQuery('#docs-list').val() ) { window.open( 'http://api.wordpress.org/core/handbook/1.0/?function=' + escape( jQuery( '#docs-list' ).val() ) + '&amp;locale=<?php echo urlencode( get_locale() ) ?>&amp;version=<?php echo urlencode( $wp_version ) ?>&amp;redirect=true'); }" />
         </div>
     <?php } ?>