Changeset 14933

Timestamp:

05/26/2010 04:55:21 AM (14 years ago)

Author:

nacin

Message:

Separate out multiple _ajax_nonce fields on post forms. Yay, validation. fixes #13383.

Location:

trunk/wp-admin

Files:

• admin-ajax.php (modified) (4 diffs)
• includes/meta-boxes.php (modified) (1 diff)
• includes/template.php (modified) (2 diffs)

trunk/wp-admin/admin-ajax.php

@@ -219 +219 @@
     $action = $_POST['action'];
     $taxonomy = get_taxonomy(substr($action, 4));
-    check_ajax_referer( $action );
+    check_ajax_referer( $action, '_ajax_nonce-add-' . $taxonomy->name );
     if ( !current_user_can( $taxonomy->cap->edit_terms ) )
         die('-1');
@@ -703 +703 @@
     break;
 case 'replyto-comment' :
-    check_ajax_referer( $action );
+    check_ajax_referer( $action, '_ajax_nonce-replyto-comment' );
 
     $comment_post_ID = (int) $_POST['comment_post_ID'];
@@ -772 +772 @@
     break;
 case 'edit-comment' :
-    check_ajax_referer( 'replyto-comment' );
+    check_ajax_referer( 'replyto-comment', '_ajax_nonce-replyto-comment' );
 
     $comment_post_ID = (int) $_POST['comment_post_ID'];
@@ -846 +846 @@
     break;
 case 'add-meta' :
-    check_ajax_referer( 'add-meta' );
+    check_ajax_referer( 'add-meta', '_ajax_nonce-add-meta' );
     $c = 0;
     $pid = (int) $_POST['post_id'];

trunk/wp-admin/includes/meta-boxes.php

@@ -337 +337 @@
                     <?php wp_dropdown_categories( array( 'taxonomy' => $taxonomy, 'hide_empty' => 0, 'name' => 'new'.$taxonomy.'_parent', 'orderby' => 'name', 'hierarchical' => 1, 'show_option_none' => '&mdash; ' . $tax->labels->parent_item . ' &mdash;', 'tab_index' => 3 ) ); ?>
                     <input type="button" id="<?php echo $taxonomy; ?>-add-submit" class="add:<?php echo $taxonomy ?>checklist:<?php echo $taxonomy ?>-add button category-add-sumbit" value="<?php echo esc_attr( $tax->labels->add_new_item ); ?>" tabindex="3" />
-                    <?php wp_nonce_field( 'add-'.$taxonomy, '_ajax_nonce', false ); ?>
+                    <?php wp_nonce_field( 'add-'.$taxonomy, '_ajax_nonce-add-'.$taxonomy, false ); ?>
                     <span id="<?php echo $taxonomy; ?>-ajax-response"></span>
                 </p>

trunk/wp-admin/includes/template.php

@@ -2287 +2287 @@
     <input type="hidden" name="checkbox" id="checkbox" value="<?php echo $checkbox ? 1 : 0; ?>" />
     <input type="hidden" name="mode" id="mode" value="<?php echo esc_attr($mode); ?>" />
-    <?php wp_nonce_field( 'replyto-comment', '_ajax_nonce', false ); ?>
+    <?php wp_nonce_field( 'replyto-comment', '_ajax_nonce-replyto-comment', false ); ?>
     <?php wp_comment_form_unfiltered_html_nonce(); ?>
 <?php if ( $table_row ) : ?>
@@ -2463 +2463 @@
 <tr><td colspan="2" class="submit">
 <input type="submit" id="addmetasub" name="addmeta" class="add:the-list:newmeta" tabindex="9" value="<?php esc_attr_e( 'Add Custom Field' ) ?>" />
-<?php wp_nonce_field( 'add-meta', '_ajax_nonce', false ); ?>
+<?php wp_nonce_field( 'add-meta', '_ajax_nonce-add-meta', false ); ?>
 </td></tr>
 </tbody>