Changeset 15580 for trunk/wp-includes/user.php

Timestamp:

09/06/2010 11:04:50 AM (15 years ago)

Author:

scribu

Message:

Use multiple JOINs instead of CASE in _wp_meta_sql(). See #14572

File:

• trunk/wp-includes/user.php (modified) (1 diff)

trunk/wp-includes/user.php

@@ -464 +464 @@
         $meta_queries[] = wp_array_slice_assoc( $qv, array( 'meta_key', 'meta_value', 'meta_compare' ) );
 
-        $meta_query_sql = _wp_meta_sql( $meta_queries, 'user_id' );
-
-        if ( !empty( $meta_query_sql ) ) {
-            $this->query_from .= " INNER JOIN $wpdb->usermeta ON ($wpdb->users.ID = $wpdb->usermeta.user_id)";
-            $this->query_where .= $meta_query_sql;
-        }
+        list( $meta_join, $meta_where ) = _wp_meta_sql( $meta_queries, $wpdb->users, 'ID', $wpdb->usermeta, 'user_id' );
+        $this->query_from .= $meta_join;
+        $this->query_where .= $meta_where;
 
         if ( !empty($qv['include']) ) {