Changeset 15611

Timestamp:

09/12/2010 06:46:18 PM (14 years ago)

Author:

scribu

Message:

Apply filters consistently in get_*_template() functions. Fixes #14310

File:

• trunk/wp-includes/theme.php (modified) (12 diffs)

trunk/wp-includes/theme.php

@@ -688 +688 @@
 
 /**
- * Retrieve path to file without the use of extension.
- *
- * Used to quickly retrieve the path of file without including the file
- * extension. It will also check the parent template, if the file exists, with
- * the use of {@link locate_template()}. Allows for more generic file location
+ * Retrieve path to a template
+ *
+ * Used to quickly retrieve the path of a template without including the file
+ * extension. It will also check the parent theme, if the file exists, with
+ * the use of {@link locate_template()}. Allows for more generic template location
  * without the use of the other get_*_template() functions.
  *
- * Can be used with include() or require() to retrieve path.
- * <code>
- * if( '' != get_query_template( '404' ) )
- *     include( get_query_template( '404' ) );
- * </code>
- * or the same can be accomplished with
- * <code>
- * if( '' != get_404_template() )
- *     include( get_404_template() );
- * </code>
- *
  * @since 1.5.0
  *
  * @param string $type Filename without extension.
+ * @param array $templates An optional list of template candidates
  * @return string Full path to file.
  */
-function get_query_template($type) {
+function get_query_template( $type, $templates = array() ) {
     $type = preg_replace( '|[^a-z0-9-]+|', '', $type );
-    return apply_filters("{$type}_template", locate_template(array("{$type}.php")));
+
+    if ( empty( $templates ) )
+        $templates = array("{$type}.php");
+
+    $templates = apply_filters( "{$type}_template_hierarchy", $templates );
+
+    return apply_filters( "{$type}_template", locate_template( $templates ) );
 }
 
@@ -769 +765 @@
     $templates[] = 'author.php';
 
-    $template = locate_template( $templates );
-    return apply_filters( 'author_template', $template );
+    return get_query_template( 'author', $templates );
 }
 
@@ -791 +786 @@
     $templates = array();
 
-    if ( !is_wp_error($category) )
+    if ( !is_wp_error( $category ) )
         $templates[] = "category-{$category->slug}.php";
 
@@ -797 +792 @@
     $templates[] = "category.php";
 
-    $template = locate_template($templates);
-    return apply_filters('category_template', $template);
+    return get_query_template( 'category', $templates );
 }
 
@@ -825 +819 @@
     $templates[] = "tag.php";
 
-    $template = locate_template($templates);
-    return apply_filters('tag_template', $template);
+    return get_query_template( 'tag', $templates );
 }
 
@@ -858 +851 @@
     $templates[] = "taxonomy.php";
 
-    $template = locate_template($templates);
-    return apply_filters('taxonomy_template', $template);
+    return get_query_template( 'taxonomy', $templates );
 }
 
@@ -886 +878 @@
  */
 function get_home_template() {
-    $template = locate_template(array('home.php', 'index.php'));
-    return apply_filters('home_template', $template);
+    $templates = array( 'home.php', 'index.php' );
+
+    return get_query_template( 'home', $templates );
 }
 
@@ -901 +894 @@
  */
 function get_front_page_template() {
-    return apply_filters( 'front_page_template', locate_template( array('front-page.php') ) );
+    $templates = array('front-page.php');
+
+    return get_query_template( 'front_page', $templates );
 }
 
@@ -940 +935 @@
     $templates[] = "page.php";
 
-    return apply_filters('page_template', locate_template($templates));
+    return get_query_template( 'page', $templates );
 }
 
@@ -977 +972 @@
     $object = $wp_query->get_queried_object();
     $templates = array('single-' . $object->post_type . '.php', 'single.php');
-    return apply_filters('single_template', locate_template($templates));
+
+    return get_query_template( 'single', $templates );
 }
 
@@ -1020 +1016 @@
  */
 function get_comments_popup_template() {
-    $template = locate_template(array("comments-popup.php"));
+    $template = get_query_template( 'comments_popup', array( 'comments-popup.php' ) );
 
     // Backward compat code will be removed in a future release
@@ -1026 +1022 @@
         $template = ABSPATH . WPINC . '/theme-compat/comments-popup.php';
 
-    return apply_filters('comments_popup_template', $template);
+    return $template;
 }