Changeset 15632 for trunk/wp-admin/admin-ajax.php

Timestamp:

09/18/2010 07:30:53 PM (14 years ago)

Author:

scribu

Message:

WP_Terms_Table cleanup:

• use column_*() methods
• remove $taxonomy argument from single_row()
• don't calculate tag full name in admin-ajax.php

See #14579

File:

• trunk/wp-admin/admin-ajax.php (modified) (3 diffs)

trunk/wp-admin/admin-ajax.php

@@ -560 +560 @@
 
     $level = 0;
-    $tag_full_name = false;
-    $tag_full_name = $tag->name;
     if ( is_taxonomy_hierarchical($taxonomy) ) {
-        $_tag = $tag;
-        while ( $_tag->parent  ) {
-            $_tag = get_term( $_tag->parent, $taxonomy );
-            $tag_full_name = $_tag->name . ' — ' . $tag_full_name;
-            $level++;
-        }
-        $noparents = $wp_list_table->single_row( $tag, $level, $taxonomy );
-    }
-    $tag->name = $tag_full_name;
-    $parents = $wp_list_table->single_row( $tag, 0, $taxonomy);
+        $level = count( get_ancestors( $tag->term_id, $taxonomy ) );
+        ob_start();
+        $wp_list_table->single_row( $tag, $level );
+        $noparents = ob_get_clean();
+    }
+
+    ob_start();
+    $wp_list_table->single_row( $tag );
+    $parents = ob_get_clean();
 
     $x->add( array(
@@ -581 +578 @@
         'what' => 'term',
         'position' => $level,
-        'supplemental' => get_term( $tag->term_id, $taxonomy, ARRAY_A ) // Refetch as $tag has been contaminated by the full name.
+        'supplemental' => $tag
         ) );
     $x->send();
@@ -1228 +1225 @@
         }
 
-        echo $wp_list_table->single_row( $tag, 0, $taxonomy );
+        echo $wp_list_table->single_row( $tag );
     } else {
         if ( is_wp_error($updated) && $updated->get_error_message() )