Changeset 15667

Timestamp:

09/26/2010 10:56:36 AM (14 years ago)

Author:

dd32

Message:

Partially revert [15642]. Fixes Bulk deletion of non-media items. As a bonus, exit on redirects & check the post status is valid before querying it. See #14579

File:

• trunk/wp-admin/edit.php (modified) (2 diffs)

trunk/wp-admin/edit.php

@@ -32 +32 @@
 
     if ( 'delete_all' == $doaction ) {
-        $post_ids = $wpdb->get_col( "SELECT ID FROM $wpdb->posts WHERE post_type='attachment' AND post_status = 'trash'" );
+        $post_status = preg_replace('/[^a-z0-9_-]+/i', '', $_REQUEST['post_status']);
+        if ( get_post_status_object($post_status) ) // Check the post status exists first
+            $post_ids = $wpdb->get_col( $wpdb->prepare( "SELECT ID FROM $wpdb->posts WHERE post_type=%s AND post_status = %s", $post_type, $post_status ) );
         $doaction = 'delete';
     } elseif ( isset( $_REQUEST['media'] ) ) {
@@ -38 +40 @@
     } elseif ( isset( $_REQUEST['ids'] ) ) {
         $post_ids = explode( ',', $_REQUEST['ids'] );
+    } elseif ( !empty( $_REQUEST['post'] ) ) {
+        $post_ids = array_map('intval', $_REQUEST['post']);
     }
 
     if ( !isset( $post_ids ) ) {
         wp_redirect( admin_url("edit.php?post_type=$post_type") );
+        exit;
     }