Changeset 15806 for trunk/wp-includes/post.php

Timestamp:

10/14/2010 03:09:04 PM (14 years ago)

Author:

ryan

Message:

Prevent post and term hierarchy loops. Props mdawaffe. fixes #14662

File:

• trunk/wp-includes/post.php (modified) (2 diffs)

trunk/wp-includes/post.php

@@ -2338 +2338 @@
         $post_parent = 0;
 
-    if ( !empty($post_ID) ) {
-        if ( $post_parent == $post_ID ) {
-            // Post can't be its own parent
-            $post_parent = 0;
-        } elseif ( !empty($post_parent) ) {
-            $parent_post = get_post($post_parent);
-            // Check for circular dependency
-            if ( isset( $parent_post->post_parent ) && $parent_post->post_parent == $post_ID )
-                $post_parent = 0;
-        }
-    }
+    // Check the post_parent to see if it will cause a hierarchy loop
+    $post_parent = apply_filters( 'wp_insert_post_parent', $post_parent, $post_ID, compact( array_keys( $postarr ) ), $postarr );
 
     if ( isset($menu_order) )
@@ -4805 +4796 @@
 }
 
+/**
+ * Returns the post's parent's post_ID
+ *
+ * @since 3.1
+ *
+ * @param int $post_id
+ *
+ * @return int|bool false on error
+ */
+function wp_get_post_parent_id( $post_ID ) {
+    $post = get_post( $post_ID );
+    if ( !$post || is_wp_error( $post ) )
+        return false;
+    return (int) $post->post_parent;
+}
+
+/**
+ * Checks the given subset of the post hierarchy for hierarchy loops.
+ * Prevents loops from forming and breaks those that it finds.
+ *
+ * Attached to the wp_insert_post_parent filter.
+ *
+ * @since 3.1
+ * @uses wp_find_hierarchy_loop()
+ *
+ * @param int $post_parent ID of the parent for the post we're checking.
+ * @parem int $post_ID ID of the post we're checking.
+ *
+ * @return int The new post_parent for the post.
+ */
+function wp_check_post_hierarchy_for_loops( $post_parent, $post_ID ) {
+    // Nothing fancy here - bail
+    if ( !$post_parent )
+        return 0;
+
+    // New post can't cause a loop
+    if ( empty( $post_ID ) )
+        return $post_parent;
+
+    // Can't be its own parent
+    if ( $post_parent == $post_ID )
+        return 0;
+
+    // Now look for larger loops
+
+    if ( !$loop = wp_find_hierarchy_loop( 'wp_get_post_parent_id', $post_ID, $post_parent ) )
+        return $post_parent; // No loop
+
+    // Setting $post_parent to the given value causes a loop
+    if ( isset( $loop[$post_ID] ) )
+        return 0;
+
+    // There's a loop, but it doesn't contain $post_ID.  Break the loop.
+    foreach ( array_keys( $loop ) as $loop_member )
+        wp_update_post( array( 'ID' => $loop_member, 'post_parent' => 0 ) );
+
+    return $post_parent;
+}
 
 /**