Changeset 16003

Timestamp:

10/27/2010 08:27:45 AM (13 years ago)

Author:

nacin

Message:

Add a 'Sticky' filter on the edit posts page. Add post_in and post_not_in as private query vars in the WP class to support this. fixes #8466.

Location:

trunk

Files:

• wp-admin/includes/list-table-posts.php (modified) (5 diffs)
• wp-admin/includes/post.php (modified) (2 diffs)
• wp-includes/classes.php (modified) (1 diff)

trunk/wp-admin/includes/list-table-posts.php

@@ -22 +22 @@
      *
      * @since 3.1.0
-     * @var bool
+     * @var int
      * @access protected
      */
@@ -31 +31 @@
      *
      * @since 3.1.0
-     * @var bool
+     * @var int
      * @access private
      */
     var $user_posts_count;
+
+    /**
+     * Holds the number of posts which are sticky.
+     *
+     * @since 3.1.0
+     * @var int
+     * @access private
+     */
+    var $sticky_posts_count = 0;
 
     function WP_Posts_Table() {
@@ -52 +61 @@
             $this->user_posts_count = $wpdb->get_var( $wpdb->prepare( "
                 SELECT COUNT( 1 ) FROM $wpdb->posts
-                WHERE post_type = '%s' AND post_status NOT IN ( 'trash', 'auto-draft' )
+                WHERE post_type = %s AND post_status NOT IN ( 'trash', 'auto-draft' )
                 AND post_author = %d
             ", $post_type, get_current_user_id() ) );
 
-            if ( $this->user_posts_count && empty( $_REQUEST['post_status'] ) && empty( $_REQUEST['all_posts'] ) && empty( $_REQUEST['author'] ) )
+            if ( $this->user_posts_count && empty( $_REQUEST['post_status'] ) && empty( $_REQUEST['all_posts'] ) && empty( $_REQUEST['author'] ) && empty( $_REQUEST['show_sticky'] ) )
                 $_GET['author'] = get_current_user_id();
+        }
+
+        if ( $sticky_posts = get_option( 'sticky_posts' ) ) {
+            $sticky_posts = implode( ', ', array_map( 'absint', (array) $sticky_posts ) );
+            $this->sticky_posts_count = $wpdb->get_var( $wpdb->prepare( "SELECT COUNT( 1 ) FROM $wpdb->posts WHERE post_type = %s AND ID IN ($sticky_posts)", $post_type ) );
         }
 
@@ -140 +154 @@
             $total_posts -= $num_posts->$state;
 
-        $class = empty($class) && empty($_REQUEST['post_status']) ? ' class="current"' : '';
+        $class = empty( $class ) && empty( $_REQUEST['post_status'] ) && empty( $_REQUEST['show_sticky'] ) ? ' class="current"' : '';
         $status_links['all'] = "<li><a href='edit.php?post_type=$post_type{$allposts}'$class>" . sprintf( _nx( 'All <span class="count">(%s)</span>', 'All <span class="count">(%s)</span>', $total_posts, 'posts' ), number_format_i18n( $total_posts ) ) . '</a>';
 
@@ -158 +172 @@
 
             $status_links[$status_name] = "<li><a href='edit.php?post_status=$status_name&amp;post_type=$post_type'$class>" . sprintf( _n( $status->label_count[0], $status->label_count[1], $num_posts->$status_name ), number_format_i18n( $num_posts->$status_name ) ) . '</a>';
+        }
+
+        if ( ! empty( $this->sticky_posts_count ) ) {
+            $class = ! empty( $_REQUEST['show_sticky'] ) ? ' class="current"' : '';
+
+            $sticky_link = array( 'sticky' => "<li><a href='edit.php?post_type=$post_type&amp;show_sticky=1'$class>" . sprintf( _nx( 'Sticky <span class="count">(%s)</span>', 'Sticky <span class="count">(%s)</span>', $this->sticky_posts_count, 'posts' ), number_format_i18n( $this->sticky_posts_count ) ) . '</a>' );
+
+            // Sticky comes after Publish, or if not listed, after All.
+            $split = 1 + array_search( ( isset( $status_links['publish'] ) ? 'publish' : 'all' ), array_keys( $status_links ) );
+            $status_links = array_merge( array_slice( $status_links, 0, $split ), $sticky_link, array_slice( $status_links, $split ) );
         }
 

trunk/wp-admin/includes/post.php

@@ -854 +854 @@
     }
 
+    if ( ! empty( $q['show_sticky'] ) )
+        $query['post__in'] = (array) get_option( 'sticky_posts' );
+
     wp( $query );
 
@@ -921 +924 @@
         add_filter('posts_where', '_edit_attachments_query_helper');
 
-    wp($q);
+    wp( $q );
 
     if ( isset($q['detached']) )

trunk/wp-includes/classes.php

@@ -37 +37 @@
      * @var array
      */
-    var $private_query_vars = array('offset', 'posts_per_page', 'posts_per_archive_page', 'showposts', 'nopaging', 'post_type', 'post_status', 'category__in', 'category__not_in', 'category__and', 'tag__in', 'tag__not_in', 'tag__and', 'tag_slug__in', 'tag_slug__and', 'tag_id', 'post_mime_type', 'perm', 'comments_per_page');
+    var $private_query_vars = array('offset', 'posts_per_page', 'posts_per_archive_page', 'showposts', 'nopaging', 'post_type', 'post_status', 'category__in', 'category__not_in', 'category__and', 'tag__in', 'tag__not_in', 'tag__and', 'tag_slug__in', 'tag_slug__and', 'tag_id', 'post_mime_type', 'perm', 'comments_per_page', 'post__in', 'post__not_in');
 
     /**