Changeset 16372 for trunk/wp-admin/includes/class-wp-plugins-list-table.php

Timestamp:

11/14/2010 06:34:59 PM (14 years ago)

Author:

scribu

Message:

Don't display upgradeable plugins in site admin and only translate plugin data for currently displayed plugins. See #14435

File:

• trunk/wp-admin/includes/class-wp-plugins-list-table.php (modified) (4 diffs)

trunk/wp-admin/includes/class-wp-plugins-list-table.php

@@ -65 +65 @@
             if ( apply_filters( 'show_advanced_plugins', true, 'dropins' ) )
                 $plugins['dropins'] = get_dropins();
+
+            $current = get_site_transient( 'update_plugins' );
+            foreach ( (array) $plugins['all'] as $plugin_file => $plugin_data ) {
+                if ( isset( $current->response[ $plugin_file ] ) )
+                    $plugins['upgrade'][ $plugin_file ] = $plugin_data;
+            }
         }
 
@@ -76 +82 @@
                 unset( $recently_activated[$key] );
         update_option( 'recently_activated', $recently_activated );
-
-        $current = get_site_transient( 'update_plugins' );
-
-        foreach ( array( 'all', 'mustuse', 'dropins' ) as $type ) {
-            foreach ( (array) $plugins[$type] as $plugin_file => $plugin_data ) {
-                // Translate, Apply Markup, Sanitize HTML
-                $plugins[$type][$plugin_file] = _get_plugin_data_markup_translate( $plugin_file, $plugin_data, false, true );
-            }
-        }
 
         foreach ( (array) $plugins['all'] as $plugin_file => $plugin_data ) {
@@ -101 +98 @@
                 $plugins['inactive'][ $plugin_file ] = $plugin_data;
             }
-
-            if ( isset( $current->response[ $plugin_file ] ) )
-                $plugins['upgrade'][ $plugin_file ] = $plugin_data;
         }
 
@@ -121 +115 @@
             $status = 'all';
 
-        $this->items = $plugins[ $status ];
+        $this->items = array();
+        foreach ( $plugins[ $status ] as $plugin_file => $plugin_data ) {
+            // Translate, Apply Markup, Sanitize HTML
+            $this->items[$plugin_file] = _get_plugin_data_markup_translate( $plugin_file, $plugin_data, false, true );
+        }
+
         $total_this_page = $totals[ $status ];