Changeset 16638

Timestamp:

11/30/2010 10:49:56 PM (14 years ago)

Author:

markjaquith

Message:

Drop pingback/trackback blogroll whitelisting feature. Too many ways to abuse it. props avereha. props vladimir_kolesnikov. fixes #13887 for 3.0.x

File:

• branches/3.0/wp-includes/comment.php (modified) (2 diffs)

branches/3.0/wp-includes/comment.php

@@ -19 +19 @@
  * then the check fails.
  *
- * If the comment is a trackback and part of the blogroll, then the trackback is
- * automatically whitelisted. If the comment author was approved before, then
- * the comment is automatically whitelisted.
+ * If the comment author was approved before, then the comment is
+ * automatically whitelisted.
  *
  * If none of the checks fail, then the failback is to set the check to pass
@@ -81 +80 @@
     // Comment whitelisting:
     if ( 1 == get_option('comment_whitelist')) {
-        if ( 'trackback' == $comment_type || 'pingback' == $comment_type ) { // check if domain is in blogroll
-            $uri = parse_url($url);
-            $domain = $uri['host'];
-            $uri = parse_url( home_url() );
-            $home_domain = $uri['host'];
-            if ( $wpdb->get_var($wpdb->prepare("SELECT link_id FROM $wpdb->links WHERE link_url LIKE (%s) LIMIT 1", '%'.$domain.'%')) || $domain == $home_domain )
-                return true;
-            else
-                return false;
-        } elseif ( $author != '' && $email != '' ) {
+        if ( 'trackback' != $comment_type && 'pingback' != $comment_type && $author != '' && $email != '' ) {
             // expected_slashed ($author, $email)
             $ok_to_comment = $wpdb->get_var("SELECT comment_approved FROM $wpdb->comments WHERE comment_author = '$author' AND comment_author_email = '$email' and comment_approved = '1' LIMIT 1");